Skip to content

aws: remove redundant conditional in config agent template#14734

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:aws_remove_redundant_conditional
Jul 30, 2025
Merged

aws: remove redundant conditional in config agent template#14734
efd6 merged 1 commit intoelastic:mainfrom
efd6:aws_remove_redundant_conditional

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Jul 29, 2025

Proposed commit message

aws: remove redundant conditional in config agent template

The two branches of the ternary were identical mod syntax.

Note

Thanks to @moukoublen for identifying this.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jul 29, 2025
@efd6 efd6 added Integration:aws AWS bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jul 29, 2025
The two branches of the ternary were identical mod syntax.
@efd6 efd6 force-pushed the aws_remove_redundant_conditional branch from 0517d86 to 4fffbd9 Compare July 29, 2025 21:21
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

🚀 Benchmarks report

Package aws 👍(17) 💚(2) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
rds 18518.52 12820.51 -5698.01 (-30.77%) 💔
securityhub_findings_full_posture 1436.78 1124.86 -311.92 (-21.71%) 💔
waf 7518.8 5649.72 -1869.08 (-24.86%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

cc @efd6

@elastic-sonarqube
Copy link
Copy Markdown

@efd6 efd6 marked this pull request as ready for review July 29, 2025 23:50
@efd6 efd6 requested review from a team as code owners July 29, 2025 23:50
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 merged commit 98d4d8a into elastic:main Jul 30, 2025
9 checks passed
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package aws - 3.13.3 containing this change is available at https://epr.elastic.co/package/aws/3.13.3/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:aws AWS Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants