Skip to content

[system] Fix condition in handlebar file of security data stream#14674

Merged
kpollich merged 4 commits intoelastic:mainfrom
janvi-elastic:system_security_handlebar_bugfix
Jul 24, 2025
Merged

[system] Fix condition in handlebar file of security data stream#14674
kpollich merged 4 commits intoelastic:mainfrom
janvi-elastic:system_security_handlebar_bugfix

Conversation

@janvi-elastic
Copy link
Contributor

@janvi-elastic janvi-elastic commented Jul 24, 2025

Proposed commit message

In System integration with default config, getting an error while saving the integration 
so fix if condition in handlebar file of security data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/system directory.
  • Run the following command to run tests.

elastic-package test

@janvi-elastic janvi-elastic requested review from a team as code owners July 24, 2025 11:02
@andrewkroh andrewkroh added Integration:system System Crest Contributions from Crest developement team. Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform] labels Jul 24, 2025
@elasticmachine
Copy link

elasticmachine commented Jul 24, 2025

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 24, 2025 •
edited
Loading

🚀 Benchmarks report

Package system 👍(0) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
syslog 500000 333333.33 -166666.67 (-33.33%) 💔

To see the full report comment with /test benchmark fullreport

@janvi-elastic janvi-elastic mentioned this pull request Jul 24, 2025
Merged
4 tasks
@juliaElastic juliaElastic mentioned this pull request Jul 24, 2025
Closed
@mrodm mrodm mentioned this pull request Jul 24, 2025
Merged
3 tasks
@opauloh
Copy link
Contributor

opauloh commented Jul 24, 2025

Hi @janvi-elastic

For the future, Policy testing can be added to catch errors when updating Handlebars: https://github.com/elastic/elastic-package/blob/main/docs/howto/policy_testing.md

For context, a similar error happened to me when editing the handlebars file in the Auditd Manager integration, and then we learned that policy tests spin a Kibana Snapshot to attempt to save an integration policy, which will catch errors with the handlebars. Here is how they are configured in AuditdManager

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Jul 24, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

elasticmachine commented Jul 24, 2025

💚 Build Succeeded

History

@kpollich kpollich merged commit 5cab4c9 into elastic:main Jul 24, 2025
9 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 24, 2025

Package system - 2.5.1 containing this change is available at https://epr.elastic.co/package/system/2.5.1/

@jsoriano jsoriano mentioned this pull request Aug 7, 2025
Closed
@andrewkroh andrewkroh added the bugfix Pull request that fixes a bug issue label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpollich kpollich kpollich approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

Assignees

No one assigned

Labels

bugfix Pull request that fixes a bug issue Crest Contributions from Crest developement team. Integration:system System Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@janvi-elastic @elasticmachine @opauloh @kpollich @ishleenk17 @andrewkroh