Skip to content

Rename logs to logfile#146

Merged
mtojek merged 3 commits intoelastic:masterfrom
mtojek:fix-package-input
Jul 2, 2020
Merged

Rename logs to logfile#146
mtojek merged 3 commits intoelastic:masterfrom
mtojek:fix-package-input

Conversation

@mtojek
Copy link
Copy Markdown
Contributor

@mtojek mtojek commented Jul 2, 2020

What does this PR do?

This PR is another trial of renaming logs to logfile for stream.inputs only.

I didn't update the dependency on the package-registry, as there are breaking changes (ProductRequirement is missing).

How to test this PR locally

To verify what does the new integration look like:

PACKAGES=o365 SKIP_KIBANA=true mage ImportBeats

Related issues

@mtojek mtojek added the Team:Integrations Label for the Integrations team label Jul 2, 2020
@mtojek mtojek requested a review from ruflin July 2, 2020 08:48
@mtojek mtojek self-assigned this Jul 2, 2020
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 2, 2020

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 2, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #146 opened]

  • Start Time: 2020-07-02T08:48:45.694+0000

  • Duration: 4 min 32 sec

@mtojek mtojek mentioned this pull request Jul 2, 2020
Merged
ruflin
ruflin approved these changes Jul 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM

I couldn't follow what you mean by product requirement is missing?

@mtojek
Copy link
Copy Markdown
Contributor Author

mtojek commented Jul 2, 2020

I couldn't follow what you mean by product requirement is missing?

#149

@mtojek mtojek merged commit 0e7ce58 into elastic:master Jul 2, 2020
@mtojek mtojek mentioned this pull request Jul 2, 2020
Closed
@ruflin ruflin mentioned this pull request Jul 2, 2020
Closed
29 tasks
@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Jul 2, 2020

@ph @michalpristas As a follow up, we must also adjust it in the storage so we then can remove it in the agent itself. Tracking the progress also here: elastic/package-registry#517

@jonathan-buttner I doubt this affects you.

@jonathan-buttner
Copy link
Copy Markdown

jonathan-buttner commented Jul 2, 2020

@ph @michalpristas As a follow up, we must also adjust it in the storage so we then can remove it in the agent itself. Tracking the progress also here: elastic/package-registry#517

@jonathan-buttner I doubt this affects you.

Thanks for the ping, yeah I don't think it will 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@mtojek mtojek

Labels

Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mtojek @elasticmachine @ruflin @jonathan-buttner