Skip to content

Remove os.* vars from integrations#140

Merged
mtojek merged 1 commit intoelastic:masterfrom
mtojek:fix-remove-os-vars
Jul 1, 2020
Merged

Remove os.* vars from integrations#140
mtojek merged 1 commit intoelastic:masterfrom
mtojek:fix-remove-os-vars

Conversation

@mtojek
Copy link
Copy Markdown
Contributor

@mtojek mtojek commented Jul 1, 2020

What does this PR do?

This PR remove os.* vars from integrations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
    - [ ] I have verified that all datasets collect metrics or logs.

Related issues

@mtojek mtojek added Team:Integrations Label for the Integrations team deprecation labels Jul 1, 2020
@mtojek mtojek requested a review from ruflin July 1, 2020 07:47
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)

Copy link
Copy Markdown
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-07-01T08:23:57.836+0000

  • Duration: 3 min 32 sec

@mtojek mtojek merged commit f385922 into elastic:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove generation of os specific configs

4 participants