Skip to content

[FireEye] Add Overview Dashboard#13713

Merged
kcreddy merged 4 commits intoelastic:mainfrom
moxarth-rathod:fireeye-overview-dashboard
May 7, 2025
Merged

[FireEye] Add Overview Dashboard#13713
kcreddy merged 4 commits intoelastic:mainfrom
moxarth-rathod:fireeye-overview-dashboard

Conversation

@moxarth-rathod
Copy link
Contributor

@moxarth-rathod moxarth-rathod commented Apr 29, 2025 •
edited
Loading

Proposed commit message

fireeye: add support of overview dashboard.

Currently, the integration does not include the support of dashboard hence added overview dashboard
in the integration to get better visualization of the data.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/fireeye directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Screenshots

image

@moxarth-rathod moxarth-rathod added enhancement New feature or request Integration:fireeye FireEye Network Security (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Apr 29, 2025
@moxarth-rathod moxarth-rathod self-assigned this Apr 29, 2025
@moxarth-rathod moxarth-rathod requested a review from a team as a code owner April 29, 2025 05:56
@elasticmachine
Copy link

elasticmachine commented Apr 29, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Apr 29, 2025 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the dashboard Relates to a Kibana dashboard bug, enhancement, or modification. label Apr 29, 2025
@moxarth-rathod moxarth-rathod mentioned this pull request Apr 30, 2025
Closed
6 tasks
kcreddy
kcreddy reviewed May 5, 2025
View reviewed changes
packages/fireeye/img/fireeye-overview.png
Copy link
Contributor

@kcreddy kcreddy May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an overview dashboard, it makes sense to use event.module: fireeye just in case in the future more data_streams are added

Copy link
Contributor Author

@moxarth-rathod moxarth-rathod May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, i've updated the filter here.

packages/fireeye/img/fireeye-overview.png
Copy link
Contributor

@kcreddy kcreddy May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a saved search

@moxarth-rathod moxarth-rathod force-pushed the fireeye-overview-dashboard branch from 1d7c21b to c3e219f Compare May 6, 2025 09:19
@moxarth-rathod moxarth-rathod requested a review from kcreddy May 6, 2025 09:21
kcreddy
kcreddy reviewed May 6, 2025
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moxarth-rathod please check the CI failure.

@elasticmachine
Copy link

elasticmachine commented May 6, 2025

💚 Build Succeeded

History

cc @moxarth-rathod

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented May 6, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
98.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@moxarth-rathod moxarth-rathod requested a review from kcreddy May 7, 2025 04:12
@kcreddy kcreddy merged commit 10d5b9c into elastic:main May 7, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented May 7, 2025

Package fireeye - 1.26.0 containing this change is available at https://epr.elastic.co/package/fireeye/1.26.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@moxarth-rathod moxarth-rathod

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:fireeye FireEye Network Security (Community supported) Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@moxarth-rathod @elasticmachine @kcreddy @andrewkroh