Skip to content

Add tips for fields files#137

Merged
mtojek merged 2 commits intoelastic:masterfrom
mtojek:tips-2-fields
Jun 30, 2020
Merged

Add tips for fields files#137
mtojek merged 2 commits intoelastic:masterfrom
mtojek:tips-2-fields

Conversation

@mtojek
Copy link
Copy Markdown
Contributor

@mtojek mtojek commented Jun 30, 2020

@mtojek mtojek requested a review from narph June 30, 2020 12:50
@mtojek mtojek self-assigned this Jun 30, 2020
@mtojek mtojek added the Team:Integrations Label for the Integrations team label Jun 30, 2020
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #137 opened]

  • Start Time: 2020-06-30T12:58:56.954+0000

  • Duration: 3 min 21 sec

@narph
Copy link
Copy Markdown
Contributor

narph commented Jun 30, 2020

@mtojek , great addition on the tips, thanks for adding the package-fields.yml point, I was wondering if we should add the new steps for updating the README files or they should be somewhere else?

@mtojek
Copy link
Copy Markdown
Contributor Author

mtojek commented Jun 30, 2020

Hmm.. not sure actually. I didn't have intention to do this as it's part of the "mage check". If you see a place in which it would beneficial to add, I can do this!

@narph
Copy link
Copy Markdown
Contributor

narph commented Jun 30, 2020

Hmm.. not sure actually. I didn't have intention to do this as it's part of the "mage check". If you see a place in which it would beneficial to add, I can do this!

Somehow missed the - enabled by default in "mage check" part, LGTM

@mtojek mtojek merged commit 9bbb38f into elastic:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants