Move system dashboards to cpu.*.norm.pct#1358
Merged
fearful-symmetry merged 6 commits intoelastic:masterfrom Jul 29, 2021
Merged
Move system dashboards to cpu.*.norm.pct#1358fearful-symmetry merged 6 commits intoelastic:masterfrom
fearful-symmetry merged 6 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
mtojek
reviewed
Jul 27, 2021
Contributor
mtojek
left a comment
There was a problem hiding this comment.
CI complains about formatting.
mtojek
approved these changes
Jul 28, 2021
| "metrics": [ | ||
| { | ||
| "field": "system.cpu.user.pct", | ||
| "field": "system.cpu.user.norm.pct", |
Contributor
There was a problem hiding this comment.
Do you think we should remove the other field? Field definition
Contributor
Author
There was a problem hiding this comment.
Just going to merge this since it's been approved, but I'm not quite sure what you mean here? Are you saying we should remove the field definition you linked to?
Contributor
There was a problem hiding this comment.
If it isn't used anymore, then yes we should.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This migrates the system dashboards to using
norm.pctfor CPU visualizations, so any bars/gauges/etc, don't go past 100%, in theory making the visualizations a little more user-friendly. We've had the current metrics tied to the visualizations for a while, and I'm not sure if there was a reason why we weren't usingnorm, but I've tested everything, and it seems fine. Also--is it standard practice to update the integration first, or metricbeat first? Does it matter?Checklist
changelog.ymlfile.