Add support for Azure Spring Cloud logs#1355
Add support for Azure Spring Cloud logs#1355narph merged 19 commits intoelastic:masterfrom narph:azure-spring
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
|
@sorantis , @hemantmalik , I have added the logs format and dashboards in the description, let me know what you think |
|
Hey, @narph those are looking great. Thank you for sharing the update. |
| type: keyword | ||
| - name: ecs.version | ||
| external: ecs | ||
| description: ECS version |
There was a problem hiding this comment.
If you load an external field, you don't need to add descriptions here (I'm not sure if we have overriding feature implemented).
| external: ecs | ||
| - name: event | ||
| external: ecs | ||
| - name: host |
There was a problem hiding this comment.
You have to mention all leaf-fields not just groups. We don't want to import definitions for all fields behind host, but just ones that are actually used. Unfortunately the tool can't figure it out on it's own.
| @@ -1,249 +1,28 @@ | |||
| - description: IP address of the client. | |||
| name: client.ip | |||
There was a problem hiding this comment.
Fields defining client family is here: https://github.com/elastic/ecs/blob/master/generated/beats/fields.ecs.yml#L147
mtojek
left a comment
There was a problem hiding this comment.
Just one comment about the ecs.yml file. Otherwise it LGTM, please wait for the CI status.
| @@ -0,0 +1,27 @@ | |||
| - name: ecs.version | |||
There was a problem hiding this comment.
I guess you don't need this file now.
PR description will be updated soon
What does this PR do?
Add support for Azure Spring Cloud logs
Checklist
changelog.ymlfile.manifest.ymlfile to point to the latest Elastic stack release (e.g.^7.13.0).Author's Checklist
How to test this PR locally
Related issues
Example:
Screenshots