[MS365] [Subscriptions] Add Subscriptions data stream#12490
Merged
lucian-ioan merged 3 commits intoelastic:mainfrom Feb 5, 2025
Merged
[MS365] [Subscriptions] Add Subscriptions data stream#12490lucian-ioan merged 3 commits intoelastic:mainfrom
lucian-ioan merged 3 commits intoelastic:mainfrom
Conversation
2a84663 to
77c002c
Compare
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
outlook_app_usage_version_counts |
10869.57 | 4975.12 | -5894.45 (-54.23%) | 💔 |
sharepoint_site_usage_detail |
7812.5 | 5347.59 | -2464.91 (-31.55%) | 💔 |
teams_device_usage_user_counts |
5464.48 | 4065.04 | -1399.44 (-25.61%) | 💔 |
viva_engage_device_usage_user_counts |
10309.28 | 6802.72 | -3506.56 (-34.01%) | 💔 |
viva_engage_groups_activity_group_detail |
8771.93 | 6134.97 | -2636.96 (-30.06%) | 💔 |
active_users_services_user_counts |
3717.47 | 2604.17 | -1113.3 (-29.95%) | 💔 |
groups_activity_group_detail |
2590.67 | 1766.78 | -823.89 (-31.8%) | 💔 |
onedrive_usage_account_counts |
16666.67 | 13333.33 | -3333.34 (-20%) | 💔 |
onedrive_usage_account_detail |
4201.68 | 2369.67 | -1832.01 (-43.6%) | 💔 |
onedrive_usage_file_counts |
15151.52 | 12658.23 | -2493.29 (-16.46%) | 💔 |
outlook_activity |
9900.99 | 4566.21 | -5334.78 (-53.88%) | 💔 |
To see the full report comment with /test benchmark fullreport
ritalwar
reviewed
Jan 28, 2025
packages/o365_metrics/data_stream/subscriptions/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/o365_metrics/data_stream/subscriptions/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/o365_metrics/data_stream/subscriptions/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Please check if we need to fingerprint over any field(dimension)
Contributor
Author
There was a problem hiding this comment.
There isn't any identifier field here between documents. I used a fingerprint for the entire accounts list.
ritalwar
reviewed
Jan 29, 2025
packages/o365_metrics/data_stream/subscriptions/sample_event.json
Outdated
Show resolved
Hide resolved
muthu-mps
reviewed
Jan 30, 2025
packages/o365_metrics/data_stream/subscriptions/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
muthu-mps
reviewed
Jan 30, 2025
.github/CODEOWNERS
Outdated
Contributor
There was a problem hiding this comment.
@lucian-ioan - Can you resolve conflicts, The code owner file already has this change.
Suggested change
| /packages/o365_metrics/data_stream/yammer_device_usage @elastic/obs-infraobs-integrations |
ritalwar
approved these changes
Jan 30, 2025
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
43f8496 to
bbb377e
Compare
efd6
reviewed
Jan 30, 2025
Contributor
There was a problem hiding this comment.
There should probably be an assessment for the presence of a CEL error condition like we have e.g. here.
Comment on lines
58
to
73
bbb377e to
8e96189
Compare
|
💚 Build Succeeded
History
cc @lucian-ioan |
|
Package o365_metrics - 0.5.0 containing this change is available at https://epr.elastic.co/package/o365_metrics/0.5.0/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add subscriptions data stream.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots