[prometheus] add event.module and event.dataset#1249
Merged
endorama merged 5 commits intoelastic:masterfrom Jun 30, 2021
endorama:prometheus-event-module
Merged
[prometheus] add event.module and event.dataset#1249endorama merged 5 commits intoelastic:masterfrom endorama:prometheus-event-module
endorama merged 5 commits intoelastic:masterfrom
endorama:prometheus-event-module
Conversation
Add `module.event` and `module.dataset` to all data streams in prometheus package. From changes discussed in elastic/security-team#780
|
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
mtojek
reviewed
Jun 30, 2021
Contributor
mtojek
left a comment
There was a problem hiding this comment.
Please make sure to bump up kibana version constraint:
conditions:
kibana.version: "^7.14.0"
packages/prometheus/changelog.yml
Outdated
| # newer versions go on top | ||
| - version: "0.4.0" | ||
| changes: | ||
| - description: Set `module.event` and `module.dataset` |
Contributor
There was a problem hiding this comment.
nit: event.module and event.dataset
nit: same in the PR description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
event.moduleandevent.datasetto all data streams in prometheus package.From changes discussed in https://github.com/elastic/security-team/issues/780
Checklist
changelog.ymlfile.manifest.ymlfile to point to the latest Elastic stack release (e.g.^7.13.0).I didn't run
elastic-package testas I'm still setting up all the required environment.