Skip to content

[windows] Use wildcard field type#1161

Merged
marc-gr merged 1 commit intoelastic:masterfrom
marc-gr:windows-wildcard
Jun 23, 2021
Merged

[windows] Use wildcard field type#1161
marc-gr merged 1 commit intoelastic:masterfrom
marc-gr:windows-wildcard

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Jun 22, 2021 •
edited
Loading

What does this PR do?

Uses wildcard field type for the relevant ECS fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

@marc-gr marc-gr force-pushed the windows-wildcard branch from c240ae5 to 5f2c053 Compare June 22, 2021 08:24
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 22, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-06-23T11:17:16.098+0000

  • Duration: 22 min 47 sec

  • Commit: 9235a72

Test stats 🧪

Test Results
Failed 0
Passed 126
Skipped 0
Total 126

Trends 🧪

Image of Build Times

Image of Tests

@marc-gr marc-gr mentioned this pull request Jun 22, 2021
Closed
43 tasks
@marc-gr marc-gr force-pushed the windows-wildcard branch from a29f7ea to 84f24d2 Compare June 23, 2021 09:14
@marc-gr marc-gr changed the title [windows] Use wildcard type [windows] Use referenced ECS fields Jun 23, 2021
@marc-gr marc-gr force-pushed the windows-wildcard branch from 84f24d2 to 346574f Compare June 23, 2021 09:15
@marc-gr marc-gr force-pushed the windows-wildcard branch from 346574f to 9235a72 Compare June 23, 2021 09:29
@marc-gr marc-gr changed the title [windows] Use referenced ECS fields [windows] Use wildcard field type Jun 23, 2021
@marc-gr marc-gr mentioned this pull request Jun 23, 2021
Closed
10 tasks
P1llus
P1llus approved these changes Jun 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

P1llus
P1llus approved these changes Jun 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr merged commit 7333672 into elastic:master Jun 23, 2021
@marc-gr marc-gr deleted the windows-wildcard branch June 23, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@P1llus P1llus P1llus approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marc-gr @elasticmachine @P1llus