Merged
Conversation
1728494 to
c3e0023
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
43 tasks
c3e0023 to
f1025e2
Compare
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
P1llus
approved these changes
Jun 15, 2021
Member
P1llus
left a comment
There was a problem hiding this comment.
LGTM, just added a quick comment
packages/o365/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
loginput only used for system tests.o365auditinput, which was inadvertently broken due to the lack of system tests:o365auditinput does not have a rawmessagefield to parse, but ao365auditobject already parsed.apisetting type toyaml.tenant_namesdescription and configuration: the option is atextbut was treated like an object, which was causing the tests to break. This was not showing up in tests because the option was not set in the system tests for theloginput.o365auditChecklist
changelog.ymlfile.manifest.ymlfile to point to the latest Elastic stack release (e.g.^7.13.0).Related issues