[CI] Add support to run system tests with different Elastic Agent docker images#10885
Closed
mrodm wants to merge 5 commits intoelastic:mainfrom
Closed
[CI] Add support to run system tests with different Elastic Agent docker images#10885mrodm wants to merge 5 commits intoelastic:mainfrom
mrodm wants to merge 5 commits intoelastic:mainfrom
Conversation
3 tasks
🚀 Benchmarks reportTo see the full report comment with |
mrodm
commented
Aug 26, 2024
Comment on lines
+522
to
+527
| if [[ "${ELASTIC_AGENT_DOCKER_IMAGE:-""}" != "" ]]; then | ||
| echo "" | ||
| echo "Images used for Elastic Agent:" | ||
| docker ps --format "{{.Names}} {{.Image}}" |grep "elastic-agent" | ||
| echo "" | ||
| fi |
Collaborator
Author
There was a problem hiding this comment.
Do you think this information would be helpful ?
These images are not the actual Elastic Agents running the system tests, they are the images from the stack (Fleet Server and Elastic Agent). It's also true that the agents would be using the same docker image as a base image.
💔 Build Failed
Failed CI StepsHistory
cc @mrodm |
|
Collaborator
Author
|
Closing PR, the latest changes applied in elastic/elastic-package#2038 make not necessary to update the buildkite scripts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Proposed commit message
Add support in the CI pipeline for Pull Requests to run system tests with different Elastic Agent docker images.
This is achieved by setting the
ELASTIC_AGENT_IMAGE_REF_OVERRIDEenvironment variable, as mentioned in the docs: https://github.com/elastic/elastic-package/blob/main/docs/howto/custom_images.md#use-your-own-custom-imagesAdded temporarily a log message to show the base Elastic Agent docker image used in tests:
Currently, by default
elastic-packageuses:docker.elastic.co/elastic-agent/elastic-agent-completeChecklist
[ ] I have verified that all data streams collect metrics or logs.[ ] I have added an entry to my package'schangelog.ymlfile.[ ] I have verified that Kibana version constraints are current according to guidelines.Author's Checklist
How to test this PR locally
The following steps will be performing the same changes as in this PR:
Related issues