Skip to content

Convert error.code to string for winlog inputs#10529

Merged
marc-gr merged 1 commit intoelastic:mainfrom
marc-gr:fix/winlog-convert-error.code
Jul 23, 2024
Merged

Convert error.code to string for winlog inputs#10529
marc-gr merged 1 commit intoelastic:mainfrom
marc-gr:fix/winlog-convert-error.code

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Jul 18, 2024

Proposed commit message

Convert error.code to string for winlog inputs.

Winlog integrations populate error.code coming from the windows events. The original field is a uint32, and it needs to be converted to a string to comply with the ECS error.code keyword type.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@marc-gr marc-gr added Integration:windows Windows Integration:system System Integration:microsoft_sqlserver Microsoft SQL Server Integration:hid_bravura_monitor Bravura Monitor (Partner supported) bugfix Pull request that fixes a bug issue Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform] Integration:microsoft_dnsserver Microsoft DNS Server labels Jul 18, 2024
@marc-gr marc-gr force-pushed the fix/winlog-convert-error.code branch from fe02048 to 99f80a3 Compare July 18, 2024 10:30
@marc-gr marc-gr marked this pull request as ready for review July 18, 2024 10:30
@marc-gr marc-gr requested review from a team as code owners July 18, 2024 10:30
@marc-gr marc-gr requested review from AndersonQ and leehinman July 18, 2024 10:30
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 18, 2024

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@pierrehilbert pierrehilbert added Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] labels Jul 18, 2024
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 18, 2024

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] label Jul 18, 2024
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 18, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert pierrehilbert requested review from VihasMakwana and rdner and removed request for AndersonQ and leehinman July 18, 2024 10:52
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 18, 2024

💚 Build Succeeded

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Jul 18, 2024

Quality Gate failed Quality Gate failed

Failed conditions
56.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@VihasMakwana
Copy link
Copy Markdown
Contributor

VihasMakwana commented Jul 18, 2024

@marc-gr sonar is failing. can you have a look?

@andrewkroh
Copy link
Copy Markdown
Member

andrewkroh commented Jul 18, 2024

You can ignore the sonarqube failure according to #10225 (comment).

@andrewkroh andrewkroh removed Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] labels Jul 19, 2024
ishleenk17
ishleenk17 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@marc-gr marc-gr merged commit 2565466 into elastic:main Jul 23, 2024
@marc-gr marc-gr deleted the fix/winlog-convert-error.code branch July 23, 2024 12:52
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 23, 2024

Package hid_bravura_monitor - 1.18.1 containing this change is available at https://epr.elastic.co/search?package=hid_bravura_monitor

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 23, 2024

Package microsoft_dnsserver - 0.1.1 containing this change is available at https://epr.elastic.co/search?package=microsoft_dnsserver

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 23, 2024

Package microsoft_sqlserver - 2.9.1 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 23, 2024

Package system - 1.59.3 containing this change is available at https://epr.elastic.co/search?package=system

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 23, 2024

Package windows - 1.46.1 containing this change is available at https://epr.elastic.co/search?package=windows

@andrewkroh
Copy link
Copy Markdown
Member

andrewkroh commented Sep 6, 2024

Relates: #10848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfritts nfritts nfritts approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@VihasMakwana VihasMakwana VihasMakwana approved these changes

@rdner rdner Awaiting requested review from rdner

Assignees

No one assigned

Labels

bugfix Pull request that fixes a bug issue Integration:hid_bravura_monitor Bravura Monitor (Partner supported) Integration:microsoft_dnsserver Microsoft DNS Server Integration:microsoft_sqlserver Microsoft SQL Server Integration:system System Integration:windows Windows Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@marc-gr @elasticmachine @VihasMakwana @andrewkroh @nfritts @ishleenk17 @pierrehilbert