Skip to content

Elastic Agent: ensure syslog processor is not used with 7.17.X agents#10471

Merged
pierrehilbert merged 2 commits intomainfrom
elastic-agent-syslog-fix
Jul 16, 2024
Merged

Elastic Agent: ensure syslog processor is not used with 7.17.X agents#10471
pierrehilbert merged 2 commits intomainfrom
elastic-agent-syslog-fix

Conversation

@pierrehilbert
Copy link
Copy Markdown
Contributor

@pierrehilbert pierrehilbert commented Jul 12, 2024

Proposed commit message

Elastic Agent: ensure syslog processor is not used with 7.17.X agents by adding a condition.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

Tests:

  • 7.17.22 agent is now healthy
  • 8.15.0 agent is still healthy
  • 7.17.22 agent is stuck in configuring if I reverse the condition check

How to test this PR locally

Related issues

Screenshots

@pierrehilbert pierrehilbert requested review from a team as code owners July 12, 2024 08:36
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] label Jul 12, 2024
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

@elastic-sonarqube
Copy link
Copy Markdown

@jlind23
Copy link
Copy Markdown
Contributor

jlind23 commented Jul 15, 2024

@norrietaylor @lalit-satapathy @andrewkroh can we please get people from your time to review this?

Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we expect all packages to work on Elastic Agent 7.17 even when their manifest says they require Kibana 8.x? Or is this a special case because it's the system package?

Are there CI tests for this package against 7.x?

@jlind23
Copy link
Copy Markdown
Contributor

jlind23 commented Jul 15, 2024

Do we expect all packages to work on Elastic Agent 7.17 even when their manifest says they require Kibana 8.x? Or is this a special case because it's the system package?

As we never introduced any Agent version constraints in the package manifest then users would expect them to work. If you first upgrade your stack to 8.X and then upgrade all integrations before upgrading Agents you wouldn't expect them to be broken.

Are there CI tests for this package against 7.x?

I do not think so.

@ishleenk17
Copy link
Copy Markdown
Member

ishleenk17 commented Jul 15, 2024

@pierrehilbert @cmacknz
Is this a valid scenario to expect an integration with ^8.x to work on 7.x agent?
This type of compatibility issue is likely common in many integrations where a feature has been introduced in version 8.x but is not supported in agent version 7.x.

@jlind23
Copy link
Copy Markdown
Contributor

jlind23 commented Jul 15, 2024

@ishleenk17 That what would you recommend? It also means that 7.X users won't get fixes anymore or this will break their integrations?

@ishleenk17
Copy link
Copy Markdown
Member

Approving this for now as it's a conditional check.

@ishleenk17 That what would you recommend? It also means that 7.X users won't get fixes anymore or this will break their integrations?

In general, the recommendation would be to not have a mix of versions in the stack. There can be other uncovered incompatibilities as well.

For fixing an integration in older stack version, this approach can be followed.

@jlind23
Copy link
Copy Markdown
Contributor

jlind23 commented Jul 16, 2024

In general, the recommendation would be to not have a mix of versions in the stack. There can be other uncovered incompatibilities as well.

I do agree but this is definitely not what users are doing and this can be easily proved by our telemetry.

@pierrehilbert pierrehilbert merged commit ce602de into main Jul 16, 2024
@elasticmachine
Copy link
Copy Markdown

Package system - 1.59.1 containing this change is available at https://epr.elastic.co/search?package=system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:system System Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System Integration 1.58.2 - 1.59.0 generates invalid configuration for agent 7.17.22

5 participants