Skip to content

[windows] Add system tests for httpjson input#1044

Merged
marc-gr merged 2 commits intoelastic:masterfrom
marc-gr:windows-system-tests
Jun 8, 2021
Merged

[windows] Add system tests for httpjson input#1044
marc-gr merged 2 commits intoelastic:masterfrom
marc-gr:windows-system-tests

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Jun 1, 2021 •
edited
Loading

What does this PR do?

  • Adds system tests for Splunk httpjson inputs
  • Fixed sysmon pipeline
  • Improved readme

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 1, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@marc-gr marc-gr force-pushed the windows-system-tests branch from 06f5cc1 to 9f16910 Compare June 1, 2021 10:38
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 1, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1044 updated

  • Start Time: 2021-06-08T09:20:19.307+0000

  • Duration: 18 min 7 sec

  • Commit: 176458d

Test stats 🧪

Test Results
Failed 0
Passed 126
Skipped 0
Total 126

Trends 🧪

Image of Build Times

Image of Tests

@marc-gr marc-gr mentioned this pull request Jun 1, 2021
Closed
43 tasks
P1llus
P1llus approved these changes Jun 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewkroh
andrewkroh approved these changes Jun 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/windows/data_stream/forwarded/_dev/test/system/test-default-config.yml Outdated
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an enhancement we should make stream verify the basic auth.

@marc-gr marc-gr force-pushed the windows-system-tests branch from 9f16910 to ffa113b Compare June 7, 2021 16:01
@marc-gr
Copy link
Copy Markdown
Contributor Author

marc-gr commented Jun 8, 2021

/test

@marc-gr marc-gr force-pushed the windows-system-tests branch from ffa113b to 176458d Compare June 8, 2021 09:19
@marc-gr marc-gr merged commit 5d1daa2 into elastic:master Jun 8, 2021
@marc-gr marc-gr deleted the windows-system-tests branch June 8, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@P1llus P1llus P1llus approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request Integration:windows Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marc-gr @elasticmachine @andrewkroh @P1llus