Skip to content

Add missing winlog config options#10408

Merged
marc-gr merged 3 commits intoelastic:mainfrom
marc-gr:feat/complete-winlog-configs
Jul 15, 2024
Merged

Add missing winlog config options#10408
marc-gr merged 3 commits intoelastic:mainfrom
marc-gr:feat/complete-winlog-configs

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Jul 8, 2024

Proposed commit message

Adds missing winlog options for hid bravura and sqlserver integrations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@marc-gr marc-gr added Integration:microsoft_sqlserver Microsoft SQL Server Integration:hid_bravura_monitor Bravura Monitor (Partner supported) Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform] labels Jul 8, 2024
@marc-gr marc-gr force-pushed the feat/complete-winlog-configs branch from 3c89def to a5a5c5d Compare July 8, 2024 11:13
@marc-gr marc-gr marked this pull request as ready for review July 8, 2024 11:13
@marc-gr marc-gr requested review from a team as code owners July 8, 2024 11:13
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 8, 2024

🚀 Benchmarks report

Package microsoft_sqlserver 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 1742.16 1369.86 -372.3 (-21.37%) 💔
log 12500 8771.93 -3728.07 (-29.82%) 💔

To see the full report comment with /test benchmark fullreport

@marc-gr marc-gr force-pushed the feat/complete-winlog-configs branch from a5a5c5d to d8f69a8 Compare July 8, 2024 11:46
@marc-gr marc-gr enabled auto-merge (squash) July 8, 2024 16:36
@marc-gr marc-gr requested a review from ishleenk17 July 10, 2024 12:38
@elastic-sonarqube
Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
4.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

Copy link
Copy Markdown
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@marc-gr marc-gr merged commit c599d91 into elastic:main Jul 15, 2024
@elasticmachine
Copy link
Copy Markdown

Package hid_bravura_monitor - 1.18.0 containing this change is available at https://epr.elastic.co/search?package=hid_bravura_monitor

@elasticmachine
Copy link
Copy Markdown

Package microsoft_sqlserver - 2.9.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

@marc-gr marc-gr deleted the feat/complete-winlog-configs branch July 15, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:hid_bravura_monitor Bravura Monitor (Partner supported) Integration:microsoft_sqlserver Microsoft SQL Server Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows Integrations don't render the preserve_original_event tag even when it's toggled on

5 participants