Skip to content

Add skip ignored fields for AWS WAF fields#10401

Merged
agithomas merged 1 commit intoelastic:mainfrom
agithomas:issue-10400
Jul 7, 2024
Merged

Add skip ignored fields for AWS WAF fields#10401
agithomas merged 1 commit intoelastic:mainfrom
agithomas:issue-10400

Conversation

@agithomas
Copy link
Copy Markdown
Contributor

Bug

Proposed commit message

elastic/elastic-package#1738 is adding a check to elastic-package system tests for validating _ignored fields.

Creating this PR to ignore the check for AWS WAF, for the fields

  • aws.waf.terminating_rule_match_details.location
  • aws.waf.non_terminating_matching_rules.ruleMatchDetails.location
  • aws.waf.rule_group_list.nonTerminatingMatchingRules.ruleMatchDetails.location

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

elastic-package test system -d waf -v
--- Test results for package: aws - START ---
╭─────────┬─────────────┬───────────┬───────────┬────────┬─────────────────╮
│ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │    TIME ELAPSED │
├─────────┼─────────────┼───────────┼───────────┼────────┼─────────────────┤
│ aws     │ waf         │ system    │ default   │ PASS   │ 1m45.866249876s │
╰─────────┴─────────────┴───────────┴───────────┴────────┴─────────────────╯

Related issues

Screenshots

@agithomas
Copy link
Copy Markdown
Contributor Author

/test

@elasticmachine
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

@elastic-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@agithomas agithomas marked this pull request as ready for review July 7, 2024 08:33
@agithomas agithomas requested review from a team as code owners July 7, 2024 08:33
@agithomas agithomas merged commit 8132ef6 into elastic:main Jul 7, 2024
@agithomas agithomas deleted the issue-10400 branch February 12, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AWS][WAF] System test failing for WAF with 8.14.0

4 participants