Conversation
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
P1llus
left a comment
There was a problem hiding this comment.
LGTM, I presume no one would use the logfile input either way here.
There was a problem hiding this comment.
I wonder if the new "profile" feature of elastic-package creates an issue here for the hostname. My guess is that it uses a custom docker-compose project name which would break the hardcoded name.
If stream could do a substitution where it reflects back the same hostname used in the HTTP request then that would be more portable. Or if it could substitute in an env var that would work too since it could return the container ID which should be resolvable to the client. For example:
--http-server-response-headers="next=http://{{ RequestAddr }}/api/v1/logs"
--http-server-response-headers="next=http://{{ env 'HOSTNAME' }}/api/v1/logs"
|
/test |
What does this PR do?
Checklist
changelog.ymlfile.- [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package'smanifest.ymlfile to point to the latest Elastic stack release (e.g.^7.13.0).Related issues
v0.5.0