Skip to content

Fix formatting of filesystem ignore types#10180

Merged
pierrehilbert merged 2 commits intoelastic:mainfrom
fearful-symmetry:filesystem-fix
Jun 20, 2024
Merged

Fix formatting of filesystem ignore types#10180
pierrehilbert merged 2 commits intoelastic:mainfrom
fearful-symmetry:filesystem-fix

Conversation

@fearful-symmetry
Copy link
Copy Markdown
Contributor

Proposed commit message

closes #7703

This fixes an issue where the filesystem.ignore_types: field in the integration wasn't formatting the YAML list correctly.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@fearful-symmetry fearful-symmetry added the Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] label Jun 18, 2024
@fearful-symmetry fearful-symmetry self-assigned this Jun 18, 2024
@fearful-symmetry fearful-symmetry requested review from a team as code owners June 18, 2024 17:04
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert pierrehilbert added Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform] labels Jun 18, 2024
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@pierrehilbert pierrehilbert added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Jun 18, 2024
@jlind23
Copy link
Copy Markdown
Contributor

jlind23 commented Jun 20, 2024

@lalit-satapathy @norrietaylor your teams are CODEOWNERS here, would you mind assigning someone for review please?

@ishleenk17
Copy link
Copy Markdown
Member

@fearful-symmetry : The PR number in changelog is incorrect, otherwise the change looks good!

@elasticmachine
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @fearful-symmetry

@elastic-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Copy Markdown
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pierrehilbert pierrehilbert merged commit 3d91b61 into elastic:main Jun 20, 2024
@elasticmachine
Copy link
Copy Markdown

Package system - 1.58.2 containing this change is available at https://epr.elastic.co/search?package=system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:system System Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

elastic-agent system module - filesystem.ignore_types in metricbeat is not being applied

7 participants