-
Notifications
You must be signed in to change notification settings - Fork 562
Retain event.original value upon pipeline errors #12045
Copy link
Copy link
Closed
Enhancement
3 / 33 of 3 issues completed
Copy link
Labels
Integration:AllApplies to all integrations [Integration not found in source]Applies to all integrations [Integration not found in source]Team:Security-Linux PlatformLinux Platform Security team [elastic/sec-linux-platform]Linux Platform Security team [elastic/sec-linux-platform]Team:Security-ScalabilitySecurity Integrations Scalability teamSecurity Integrations Scalability teamTeam:Security-Windows PlatformSecurity Windows Platform team [elastic/sec-windows-platform]Security Windows Platform team [elastic/sec-windows-platform]enhancementNew feature or requestNew feature or request
Metadata
Metadata
Assignees
Labels
Integration:AllApplies to all integrations [Integration not found in source]Applies to all integrations [Integration not found in source]Team:Security-Linux PlatformLinux Platform Security team [elastic/sec-linux-platform]Linux Platform Security team [elastic/sec-linux-platform]Team:Security-ScalabilitySecurity Integrations Scalability teamSecurity Integrations Scalability teamTeam:Security-Windows PlatformSecurity Windows Platform team [elastic/sec-windows-platform]Security Windows Platform team [elastic/sec-windows-platform]enhancementNew feature or requestNew feature or request
Type
Fields
Give feedbackNo fields configured for Enhancement.
When an ingest pipeline error occurs, our log pipelines should retain the
event.originalvalue to ensure that no data loss occurs and to facilitate correcting the failure. If processing is interrupted due to an error, some data may not have been extracted (i.e. incomplete processing) so it's important to retain theevent.original. And secondly, in order for the package maintainers to be able to take action on reports of pipeline failures they nearly always need theevent.originalvalue to reproduce and understand the issue.To implement this we should complete the work related to #10072. This not strictly required, but it helps ensure the
event.originalis consistently handled. We want the Fleet final_pipeline to be responsible for deleting event.original whentagsdoes not containpreserve_original_event.Next, in the primary pipeline of each log data stream we update the global
on_failurehandler to injectpreserve_original_eventintotags. This will accompanyevent.kind: pipeline_error. With this mechanism, users can still override this behavior through the various levels of@custompipelines by deleting the tag value. I expect the work to be accomplished "mechanically", and this mechanism can be applied separately on the integrations owned by each SIT team.TODO
preserve_original_eventin primary on_failure handlers