Skip to content

Commit 929449d

Browse files
niraj-elasticniraj-elastic
committed
address review comments
1 parent 7afce89 commit 929449d

File tree

7 files changed

+46
-68
lines changed

7 files changed

+46
-68
lines changed

‎packages/apache/data_stream/access/_dev/test/pipeline/test-access-basic.log-expected.json‎

Lines changed: 11 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
"@timestamp": "2016-12-26T14:16:29.000Z",
55
"apache": {
66
"access": {
7-
"identity": "-",
87
"remote_addresses": [
98
"::1"
109
]
@@ -16,7 +15,7 @@
1615
"event": {
1716
"category": "web",
1817
"created": "2020-04-28T11:07:58.223Z",
19-
"ingested": "2024-04-09T06:11:58.419585881Z",
18+
"ingested": "2024-04-26T05:46:25.296250288Z",
2019
"kind": "event",
2120
"original": "::1 - - [26/Dec/2016:16:16:29 +0200] \"GET /favicon.ico HTTP/1.1\" 404 209",
2221
"outcome": "failure"
@@ -53,7 +52,6 @@
5352
"@timestamp": "2016-12-26T16:22:13.000Z",
5453
"apache": {
5554
"access": {
56-
"identity": "-",
5755
"remote_addresses": [
5856
"192.168.33.1"
5957
]
@@ -65,7 +63,7 @@
6563
"event": {
6664
"category": "web",
6765
"created": "2020-04-28T11:07:58.223Z",
68-
"ingested": "2024-04-09T06:11:58.419621774Z",
66+
"ingested": "2024-04-26T05:46:25.296284705Z",
6967
"kind": "event",
7068
"original": "192.168.33.1 - - [26/Dec/2016:16:22:13 +0000] \"GET /hello HTTP/1.1\" 404 499 \"-\" \"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:50.0) Gecko/20100101 Firefox/50.0\"",
7169
"outcome": "failure"
@@ -115,7 +113,6 @@
115113
"@timestamp": "2016-12-26T14:16:48.000Z",
116114
"apache": {
117115
"access": {
118-
"identity": "-",
119116
"remote_addresses": [
120117
"::1"
121118
]
@@ -127,7 +124,7 @@
127124
"event": {
128125
"category": "web",
129126
"created": "2020-04-28T11:07:58.223Z",
130-
"ingested": "2024-04-09T06:11:58.419628526Z",
127+
"ingested": "2024-04-26T05:46:25.296289743Z",
131128
"kind": "event",
132129
"original": "::1 - - [26/Dec/2016:16:16:48 +0200] \"-\" 408 -",
133130
"outcome": "failure"
@@ -152,7 +149,6 @@
152149
"@timestamp": "2017-05-29T19:02:48.000Z",
153150
"apache": {
154151
"access": {
155-
"identity": "-",
156152
"remote_addresses": [
157153
"172.17.0.1"
158154
]
@@ -164,7 +160,7 @@
164160
"event": {
165161
"category": "web",
166162
"created": "2020-04-28T11:07:58.223Z",
167-
"ingested": "2024-04-09T06:11:58.419633501Z",
163+
"ingested": "2024-04-26T05:46:25.296293311Z",
168164
"kind": "event",
169165
"original": "172.17.0.1 - - [29/May/2017:19:02:48 +0000] \"GET /stringpatch HTTP/1.1\" 404 612 \"-\" \"Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120716 Firefox/15.0a2\" \"-\"",
170166
"outcome": "failure"
@@ -214,7 +210,6 @@
214210
"@timestamp": "2017-05-29T19:02:48.000Z",
215211
"apache": {
216212
"access": {
217-
"identity": "-",
218213
"remote_addresses": [
219214
"monitoring-server"
220215
]
@@ -226,7 +221,7 @@
226221
"event": {
227222
"category": "web",
228223
"created": "2020-04-28T11:07:58.223Z",
229-
"ingested": "2024-04-09T06:11:58.419638188Z",
224+
"ingested": "2024-04-26T05:46:25.296296691Z",
230225
"kind": "event",
231226
"original": "monitoring-server - - [29/May/2017:19:02:48 +0000] \"GET /status HTTP/1.1\" 200 612 \"-\" \"Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120716 Firefox/15.0a2\" \"-\"",
232227
"outcome": "success"
@@ -276,7 +271,6 @@
276271
"@timestamp": "2019-02-02T04:38:45.000Z",
277272
"apache": {
278273
"access": {
279-
"identity": "-",
280274
"remote_addresses": [
281275
"127.0.0.1"
282276
]
@@ -288,7 +282,7 @@
288282
"event": {
289283
"category": "web",
290284
"created": "2020-04-28T11:07:58.223Z",
291-
"ingested": "2024-04-09T06:11:58.419642845Z",
285+
"ingested": "2024-04-26T05:46:25.296300048Z",
292286
"kind": "event",
293287
"original": "127.0.0.1 - - [02/Feb/2019:05:38:45 +0100] \"-\" 408 152 \"-\" \"-\"",
294288
"outcome": "failure"
@@ -326,7 +320,6 @@
326320
"@timestamp": "2017-05-29T19:02:48.000Z",
327321
"apache": {
328322
"access": {
329-
"identity": "-",
330323
"remote_addresses": [
331324
"monitoring-server"
332325
]
@@ -338,7 +331,7 @@
338331
"event": {
339332
"category": "web",
340333
"created": "2020-04-28T11:07:58.223Z",
341-
"ingested": "2024-04-09T06:11:58.419647444Z",
334+
"ingested": "2024-04-26T05:46:25.296303835Z",
342335
"kind": "event",
343336
"original": "monitoring-server - - [29/May/2017:19:02:48 +0000] \"GET /A%20Beka%20G1%20Howe/029_AND_30/15%20reading%20elephants.mp4 HTTP/1.1\" 200 612 \"-\" \"Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120716 Firefox/15.0a2\" X-Forwarded-For=\"-\"",
344337
"outcome": "success"
@@ -389,7 +382,6 @@
389382
"@timestamp": "2017-05-29T19:02:48.000Z",
390383
"apache": {
391384
"access": {
392-
"identity": "-",
393385
"remote_addresses": [
394386
"10.0.0.2",
395387
"10.0.0.1",
@@ -406,7 +398,7 @@
406398
"event": {
407399
"category": "web",
408400
"created": "2020-04-28T11:07:58.223Z",
409-
"ingested": "2024-04-09T06:11:58.419652022Z",
401+
"ingested": "2024-04-26T05:46:25.296310193Z",
410402
"kind": "event",
411403
"original": "89.160.20.112 - - [29/May/2017:19:02:48 +0000] \"GET /A%20Beka%20G1%20Howe/029_AND_30/15%20reading%20elephants.mp4 HTTP/1.1\" 200 612 \"-\" \"Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120716 Firefox/15.0a2\" X-Forwarded-For=\"10.0.0.2,10.0.0.1\"",
412404
"outcome": "success"
@@ -478,7 +470,6 @@
478470
"@timestamp": "2017-05-29T19:02:48.000Z",
479471
"apache": {
480472
"access": {
481-
"identity": "-",
482473
"remote_addresses": [
483474
"10.225.192.17",
484475
"10.2.2.121",
@@ -495,7 +486,7 @@
495486
"event": {
496487
"category": "web",
497488
"created": "2020-04-28T11:07:58.223Z",
498-
"ingested": "2024-04-09T06:11:58.419656560Z",
489+
"ingested": "2024-04-26T05:46:25.296313609Z",
499490
"kind": "event",
500491
"original": "2a02:cf40:add:4002:91f2:a9b2:e09a:6fc6 - - [29/May/2017:19:02:48 +0000] \"GET /A%20Beka%20G1%20Howe/029_AND_30/15%20reading%20elephants.mp4 HTTP/1.1\" 200 612 \"-\" \"Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120716 Firefox/15.0a2\" X-Forwarded-For=\"10.225.192.17, 10.2.2.121\"",
501492
"outcome": "success"
@@ -558,7 +549,6 @@
558549
"@timestamp": "2022-05-17T21:41:43.000Z",
559550
"apache": {
560551
"access": {
561-
"identity": "-",
562552
"remote_addresses": [
563553
"192.168.0.2",
564554
"monitoring-server"
@@ -574,7 +564,7 @@
574564
"event": {
575565
"category": "web",
576566
"created": "2020-04-28T11:07:58.223Z",
577-
"ingested": "2024-04-09T06:11:58.419661112Z",
567+
"ingested": "2024-04-26T05:46:25.296316938Z",
578568
"kind": "event",
579569
"original": "monitoring-server - - [17/May/2022:21:41:43 +0000] \"GET / HTTP/1.1\" 200 45 \"-\" \"curl/7.79.1\" X-Forwarded-For=\"192.168.0.2\"",
580570
"outcome": "success"
@@ -634,7 +624,7 @@
634624
"event": {
635625
"category": "web",
636626
"created": "2020-04-28T11:07:58.223Z",
637-
"ingested": "2024-04-09T06:11:58.419665782Z",
627+
"ingested": "2024-04-26T05:46:25.296320274Z",
638628
"kind": "event",
639629
"original": "127.0.0.1 user-identity frank [10/Oct/2000:13:55:36 -0700] \"GET /apache_pb.gif HTTP/1.0\" 200 2326",
640630
"outcome": "success"

‎packages/apache/data_stream/access/_dev/test/pipeline/test-access-darwin.log-expected.json‎

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
"@timestamp": "2016-12-26T14:16:28.000Z",
55
"apache": {
66
"access": {
7-
"identity": "-",
87
"remote_addresses": [
98
"::1"
109
]
@@ -16,7 +15,7 @@
1615
"event": {
1716
"category": "web",
1817
"created": "2020-04-28T11:07:58.223Z",
19-
"ingested": "2024-04-09T06:11:58.640870130Z",
18+
"ingested": "2024-04-26T05:46:25.447843628Z",
2019
"kind": "event",
2120
"original": "::1 - - [26/Dec/2016:16:16:28 +0200] \"GET / HTTP/1.1\" 200 45",
2221
"outcome": "success"
@@ -52,7 +51,6 @@
5251
"@timestamp": "2016-12-26T14:16:29.000Z",
5352
"apache": {
5453
"access": {
55-
"identity": "-",
5654
"remote_addresses": [
5755
"::1"
5856
]
@@ -64,7 +62,7 @@
6462
"event": {
6563
"category": "web",
6664
"created": "2020-04-28T11:07:58.223Z",
67-
"ingested": "2024-04-09T06:11:58.640922672Z",
65+
"ingested": "2024-04-26T05:46:25.447895323Z",
6866
"kind": "event",
6967
"original": "::1 - - [26/Dec/2016:16:16:29 +0200] \"GET /favicon.ico HTTP/1.1\" 404 209",
7068
"outcome": "failure"
@@ -101,7 +99,6 @@
10199
"@timestamp": "2016-12-26T14:16:48.000Z",
102100
"apache": {
103101
"access": {
104-
"identity": "-",
105102
"remote_addresses": [
106103
"::1"
107104
]
@@ -113,7 +110,7 @@
113110
"event": {
114111
"category": "web",
115112
"created": "2020-04-28T11:07:58.223Z",
116-
"ingested": "2024-04-09T06:11:58.640930188Z",
113+
"ingested": "2024-04-26T05:46:25.447905030Z",
117114
"kind": "event",
118115
"original": "::1 - - [26/Dec/2016:16:16:48 +0200] \"-\" 408 -",
119116
"outcome": "failure"
@@ -138,7 +135,6 @@
138135
"@timestamp": "2016-12-26T16:23:35.000Z",
139136
"apache": {
140137
"access": {
141-
"identity": "-",
142138
"remote_addresses": [
143139
"89.160.20.156"
144140
]
@@ -150,7 +146,7 @@
150146
"event": {
151147
"category": "web",
152148
"created": "2020-04-28T11:07:58.223Z",
153-
"ingested": "2024-04-09T06:11:58.640936194Z",
149+
"ingested": "2024-04-26T05:46:25.447912585Z",
154150
"kind": "event",
155151
"original": "89.160.20.156 - - [26/Dec/2016:18:23:35 +0200] \"GET / HTTP/1.1\" 200 45",
156152
"outcome": "success"
@@ -204,7 +200,6 @@
204200
"@timestamp": "2016-12-26T16:23:41.000Z",
205201
"apache": {
206202
"access": {
207-
"identity": "-",
208203
"remote_addresses": [
209204
"89.160.20.156"
210205
]
@@ -216,7 +211,7 @@
216211
"event": {
217212
"category": "web",
218213
"created": "2020-04-28T11:07:58.223Z",
219-
"ingested": "2024-04-09T06:11:58.640941558Z",
214+
"ingested": "2024-04-26T05:46:25.447919912Z",
220215
"kind": "event",
221216
"original": "89.160.20.156 - - [26/Dec/2016:18:23:41 +0200] \"GET /notfound HTTP/1.1\" 404 206",
222217
"outcome": "failure"
@@ -270,7 +265,6 @@
270265
"@timestamp": "2016-12-26T16:23:45.000Z",
271266
"apache": {
272267
"access": {
273-
"identity": "-",
274268
"remote_addresses": [
275269
"89.160.20.156"
276270
]
@@ -282,7 +276,7 @@
282276
"event": {
283277
"category": "web",
284278
"created": "2020-04-28T11:07:58.223Z",
285-
"ingested": "2024-04-09T06:11:58.640946731Z",
279+
"ingested": "2024-04-26T05:46:25.447927217Z",
286280
"kind": "event",
287281
"original": "89.160.20.156 - - [26/Dec/2016:18:23:45 +0200] \"GET /hmm HTTP/1.1\" 404 201",
288282
"outcome": "failure"

‎packages/apache/data_stream/access/_dev/test/pipeline/test-access-ssl-request.log-expected.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"event": {
2020
"category": "web",
2121
"created": "2020-04-28T11:07:58.223Z",
22-
"ingested": "2024-04-09T06:11:58.788662911Z",
22+
"ingested": "2024-04-26T05:46:25.568940509Z",
2323
"kind": "event",
2424
"original": "[10/Aug/2018:09:45:56 +0200] 172.30.0.119 TLSv1.2 ECDHE-RSA-AES128-GCM-SHA256 \"GET /nagiosxi/ajaxhelper.php?cmd=getxicoreajax\u0026amp;opts=%7B%22func%22%3A%22get_admin_tasks_html%22%2C%22args%22%3A%22%22%7D\u0026amp;nsp=b5c7d5d4b6f7d0cf0c92f9cbdf737f6a5c838218425e6ae21 HTTP/1.1\" 1375"
2525
},
@@ -72,7 +72,7 @@
7272
"event": {
7373
"category": "web",
7474
"created": "2020-04-28T11:07:58.223Z",
75-
"ingested": "2024-04-09T06:11:58.788703961Z",
75+
"ingested": "2024-04-26T05:46:25.568967013Z",
7676
"kind": "event",
7777
"original": "[16/Oct/2019:11:53:47 +0200] 89.160.20.156 TLSv1.2 ECDHE-RSA-AES128-GCM-SHA256 \"GET /appl/ajaxhelper.php?cmd=getxicoreajax\u0026opts=%7B%22func%22%3A%22get_pagetop_alert_content_html%22%2C%22args%22%3A%22%22%7D\u0026nsp=c2700eab9797eda8a9f65a3ab17a6adbceccd60a6cca7708650a5923950d HTTP/1.1\" -"
7878
},

0 commit comments

Comments
 (0)