Skip to content

Commit 63854f0

Browse files
chrisberkhoutchrisberkhout
authored
[cisco_duo] Make the rate limit configurable (#11471)
1 parent 1b17467 commit 63854f0

9 files changed

Lines changed: 43 additions & 22 deletions

File tree

‎packages/cisco_duo/changelog.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
# newer versions go on top
2+
- version: "2.0.5"
3+
changes:
4+
- description: Make the rate limit configurable.
5+
type: bugfix
6+
link: https://github.com/elastic/integrations/pull/11471
27
- version: "2.0.4"
38
changes:
49
- description: Fix auth CEL cursor handling.

‎packages/cisco_duo/data_stream/admin/agent/stream/httpjson.yml.hbs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ request.tracer.maxbackups: 5
66
{{/if}}
77
request.method: GET
88
request.url: {{hostname}}/admin/v1/logs/administrator
9-
request.rate_limit.limit: "0.5"
9+
request.rate_limit.limit: "{{rate_limit}}"
1010
request.transforms:
1111
- set:
1212
target: url.params.mintime

‎packages/cisco_duo/data_stream/auth/agent/stream/cel.yml.hbs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ config_version: 2
22
interval: {{interval}}
33
resource.url: {{hostname}}
44
resource.rate_limit.burst: 1
5-
resource.rate_limit.limit: 0.5
5+
resource.rate_limit.limit: {{rate_limit}}
66

77
{{#if enable_request_tracer}}
88
resource.tracer.filename: "../../logs/cel/http-request-trace-*.ndjson"

‎packages/cisco_duo/data_stream/auth/agent/stream/httpjson.yml.hbs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ request.tracer.maxbackups: 5
66
{{/if}}
77
request.method: GET
88
request.url: {{hostname}}/admin/v2/logs/authentication
9-
request.rate_limit.limit: "0.5"
9+
request.rate_limit.limit: "{{rate_limit}}"
1010
request.transforms:
1111
- set:
1212
target: url.params.limit

‎packages/cisco_duo/data_stream/offline_enrollment/agent/stream/httpjson.yml.hbs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ request.tracer.filename: "../../logs/httpjson/http-request-trace-*.ndjson"
66
request.tracer.maxbackups: 5
77
{{/if}}
88
request.url: {{hostname}}/admin/v1/logs/offline_enrollment
9-
request.rate_limit.limit: "0.5"
9+
request.rate_limit.limit: "{{rate_limit}}"
1010
request.transforms:
1111
- set:
1212
target: url.params.mintime

‎packages/cisco_duo/data_stream/summary/agent/stream/httpjson.yml.hbs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ request.tracer.maxbackups: 5
66
{{/if}}
77
request.method: GET
88
request.url: {{hostname}}/admin/v1/info/summary
9-
request.rate_limit.limit: "0.5"
9+
request.rate_limit.limit: "{{rate_limit}}"
1010
request.transforms:
1111
- set:
1212
target: header.Date

‎packages/cisco_duo/data_stream/telephony/agent/stream/httpjson.yml.hbs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ request.tracer.maxbackups: 5
66
{{/if}}
77
request.method: GET
88
request.url: {{hostname}}/admin/v1/logs/telephony
9-
request.rate_limit.limit: "0.5"
9+
request.rate_limit.limit: "{{rate_limit}}"
1010
request.transforms:
1111
- set:
1212
target: url.params.mintime

‎packages/cisco_duo/data_stream/telephony_v2/agent/stream/cel.yml.hbs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ config_version: 2
22
interval: {{interval}}
33
resource.url: {{hostname}}
44
resource.rate_limit.burst: 1
5-
resource.rate_limit.limit: 0.5
5+
resource.rate_limit.limit: {{rate_limit}}
66

77
{{#if enable_request_tracer}}
88
resource.tracer.filename: "../../logs/cel/http-request-trace-*.ndjson"

‎packages/cisco_duo/manifest.yml‎

Lines changed: 31 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
format_version: "3.0.2"
22
name: cisco_duo
33
title: Cisco Duo
4-
version: "2.0.4"
4+
version: "2.0.5"
55
description: Collect logs from Cisco Duo with Elastic Agent.
66
type: integration
77
categories:
@@ -48,13 +48,6 @@ policy_templates:
4848
title: Hostname
4949
description: Hostname for the Cisco Duo Admin API (Add https:// before the hostname).
5050
required: true
51-
- name: enable_request_tracer
52-
type: bool
53-
title: Enable request tracing
54-
multi: false
55-
required: false
56-
show_user: false
57-
description: The request tracer logs requests and responses to the agent's local file-system for debugging configurations. Enabling this request tracing compromises security and should only be used for debugging. See [documentation](https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-httpjson.html#_request_tracer_filename) for details.
5851
- name: integration_key
5952
type: text
6053
title: Integration Key
@@ -74,22 +67,30 @@ policy_templates:
7467
required: true
7568
show_user: true
7669
default: 1m
77-
title: Collect Cisco Duo logs via API v1
78-
description: Collect Cisco Duo Administrator, Offline Enrollment, Summary, and Telephony (legacy) logs
79-
- type: cel
80-
vars:
81-
- name: hostname
70+
- name: rate_limit
8271
type: text
83-
title: Hostname
84-
description: Hostname for the Cisco Duo Admin API. All API methods use your API hostname, https://api-XXXXXXXX.duosecurity.com. Obtain this value from the Duo Admin Panel and use it exactly as shown there.
72+
title: Rate limit
73+
description: "The maximum per endpoint request rate, in requests per second (e.g. 0.5 reqs/sec for 30 reqs/min)."
74+
default: "0.5"
75+
multi: false
8576
required: true
77+
show_user: false
8678
- name: enable_request_tracer
8779
type: bool
8880
title: Enable request tracing
8981
multi: false
9082
required: false
9183
show_user: false
9284
description: The request tracer logs requests and responses to the agent's local file-system for debugging configurations. Enabling this request tracing compromises security and should only be used for debugging. See [documentation](https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-httpjson.html#_request_tracer_filename) for details.
85+
title: Collect Cisco Duo logs via API v1
86+
description: Collect Cisco Duo Administrator, Offline Enrollment, Summary, and Telephony (legacy) logs
87+
- type: cel
88+
vars:
89+
- name: hostname
90+
type: text
91+
title: Hostname
92+
description: Hostname for the Cisco Duo Admin API. All API methods use your API hostname, https://api-XXXXXXXX.duosecurity.com. Obtain this value from the Duo Admin Panel and use it exactly as shown there.
93+
required: true
9394
- name: integration_key
9495
type: text
9596
title: Integration Key
@@ -109,6 +110,21 @@ policy_templates:
109110
required: true
110111
show_user: true
111112
default: 1m
113+
- name: rate_limit
114+
type: text
115+
title: Rate limit
116+
description: "The maximum per endpoint request rate, in requests per second (e.g. 0.5 reqs/sec for 30 reqs/min)."
117+
default: "0.5"
118+
multi: false
119+
required: true
120+
show_user: false
121+
- name: enable_request_tracer
122+
type: bool
123+
title: Enable request tracing
124+
multi: false
125+
required: false
126+
show_user: false
127+
description: The request tracer logs requests and responses to the agent's local file-system for debugging configurations. Enabling this request tracing compromises security and should only be used for debugging. See [documentation](https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-httpjson.html#_request_tracer_filename) for details.
112128
title: Collect Cisco Duo logs via API v2
113129
description: Collect Cisco Duo Authentication, and Telephony logs
114130
owner:

0 commit comments

Comments
 (0)