golangci-lint updates and build maintenance #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the toolchain and updates configurations for golangci-lint version consistency. Key changes include:
- Adding nolint suppression comments with a TODO note in the cel extension files.
- Updating the dependency list in .golangci.yml to align with the updated toolchain.
- Adjusting GitHub workflow steps for proper checkout and specifying the golangci-lint version.
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/bundle/ruleset/engine/cel/ext/secret.go | Added a nolint comment to suppress staticcheck warnings for deprecated usage. |
| pkg/bundle/ruleset/engine/cel/ext/package.go | Added a similar nolint comment for deprecated usage. |
| .golangci.yml | Updated dependency entries; note a duplicate entry for image-spec appears. |
| .github/workflows/go.yml | Reorganized steps and updated checkout and golangci-lint action version. |
Files not reviewed (2)
- go.mod: Language not supported
- tools/go.mod: Language not supported
.golangci.yml
Outdated
| - github.com/opencontainers/image-spec | ||
| - github.com/ory/dockertest/v3 | ||
| - github.com/pelletier/go-toml | ||
| - github.com/pelletier/go-toml |
There was a problem hiding this comment.
The dependency 'github.com/opencontainers/image-spec' appears twice. Removing the duplicate entry will help avoid potential configuration conflicts.
Suggested change
| - github.com/pelletier/go-toml |
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses the following updates.
go.modandtools/go.modto enforce the use of a common tool chain.v1.64.8of golangci-lint.github workflowswith the installed tools..golangci.ymlfor golangci runner configuration.