fix: add regions for google cloud provider #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
renanvice
approved these changes
May 11, 2023
Member
There was a problem hiding this comment.
LGTM but there are some lint issues to fix before merging
Error: shadow: declaration of "e" shadows declaration at line 187 (govet)
Error: shadow: declaration of "e" shadows declaration at line 267 (govet)
Error: shadow: declaration of "i" shadows declaration at line 259 (govet)
Error: directive `// nolint:staticcheck // SSL30 disabled` should be written without leading space as `//nolint:staticcheck // SSL30 disabled` (nolintlint)
Error: directive `// nolint:gocyclo,gocognit,funlen // refactoring later` should be written without leading space as `//nolint:gocyclo,gocognit,funlen // refactoring later` (nolintlint)
Error: directive `// nolint:interfacer // Tighly coupled to type` should be written without leading space as `//nolint:interfacer // Tighly coupled to type` (nolintlint)
Error: directive `// nolint:gocognit,funlen,gocyclo // To refactor` should be written without leading space as `//nolint:gocognit,funlen,gocyclo // To refactor` (nolintlint)
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Member
Author
@renanvice lint updated pushed as apart of 93e253e |
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
ghcoi2ck
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds regions for Google Cloud to
cloudProviderRegions.