Skip to content

Fix yaml serialization from pb #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fin09pcap merged 2 commits into from
May 10, 2023
Merged

Fix yaml serialization from pb #221

fin09pcap merged 2 commits into from
May 10, 2023

Conversation

@Zenithar
Copy link
Contributor

@Zenithar Zenithar commented Sep 16, 2022

Context

  • Make owner not mandatory in RuleSetJSON Schema
  • Add a Protobuf to YAML conversion helper who uses protojson as an intermediary encoder to get the right protobuf object annotations
  • Apply fix to RuleSetand Patch tasks which were producing an api_version property instead of the expected apiVersion format
$ harp from object --in ~/demo/219/input.json --out - | harp to ruleset --in -
apiVersion: harp.elastic.co/v1
kind: RuleSet
meta:
  description: Generated from bundle content
  name: qBiWpFkYKhkuBUXyIxxA1fSWCDXV8jHBJkgArt7D2dwqZ4mn_k7s2JbomfjzB_tNEI9CJXJ1n5cflhb96ao3lA
spec:
  rules:
  - constraints:
    - p.has_secret("bar")
    name: LINT-qBiWpF-1
    path: secrets/foo/test

Reference(s)

fix #219

@Zenithar
fix(api/schemas): remove owner from mandatory fields
a587f8b 
Signed-off-by: Thibault Normand <me@zenithar.org>
@Zenithar
fix(yaml): Protobuf to YAML conversion
3a35688 
Signed-off-by: Thibault Normand <me@zenithar.org>
@fin09pcap fin09pcap merged commit 090fc3c into elastic:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fin09pcap fin09pcap fin09pcap approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

harp to ruleset defined invalid schema

2 participants

@Zenithar @fin09pcap