Skip to content

fix: update validator to use human names for IBM regions #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fin09pcap merged 9 commits into from
Jun 10, 2022
Merged

fix: update validator to use human names for IBM regions #178

fin09pcap merged 9 commits into from
Jun 10, 2022

Conversation

@fin09pcap
Copy link
Member

@fin09pcap fin09pcap commented Apr 26, 2022

fix: Updates the Validator to support the human friendly names for the IBM Cloud Regions.
test: update tests to due to being removed in daf830f

ibmcloud regions --output json
IBMCLOUD regions 
[
    {
        "Name": "au-syd",
        "DisplayName": "Sydney"
    },
    {
        "Name": "in-che",
        "DisplayName": "Chennai"
    },
    {
        "Name": "jp-osa",
        "DisplayName": "Osaka"
    },
    {
        "Name": "jp-tok",
        "DisplayName": "Tokyo"
    },
    {
        "Name": "kr-seo",
        "DisplayName": "Seoul"
    },
    {
        "Name": "eu-de",
        "DisplayName": "Frankfurt"
    },
    {
        "Name": "eu-gb",
        "DisplayName": "London"
    },
    {
        "Name": "ca-tor",
        "DisplayName": "Toronto"
    },
    {
        "Name": "us-south",
        "DisplayName": "Dallas"
    },
    {
        "Name": "us-east",
        "DisplayName": "Washington DC"
    },
    {
        "Name": "br-sao",
        "DisplayName": "Sao Paulo"
    }
]

Signed-off-by: Ben Stickel ben.stickel@elastic.co

@fin09pcap
fix: update validator to use human names for IBM regions
63dac32 
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
@fin09pcap
test: relocate bad test fixture to invalid
f40cd6b 
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
@fin09pcap
fix: add blank.yaml in invalid test fixture
092e936 
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
@fin09pcap fin09pcap self-assigned this Apr 26, 2022
fin09pcap added 4 commits May 23, 2022 22:54
@fin09pcap
fix: add ContainsString to support inspect of the region
278a5f8 
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
@fin09pcap
test: update validator tests
1ecd72a 
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
@fin09pcap
fix: add additional ibm regions aliases
e4ba176 
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
@fin09pcap
test: update paths for validtor
57fad18 
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
@fin09pcap fin09pcap force-pushed the validator/ibm_region_name_updates branch from b39786a to 57fad18 Compare May 26, 2022 06:17
@fin09pcap fin09pcap marked this pull request as ready for review May 26, 2022 06:33
@dgolja
Copy link

dgolja commented May 26, 2022

Honestly I dont even know when and how we use that. Also as @franekrichardson said dont we need to append the p0 at the end or smth ? Anyway will defer this to someone else who knows what is all about.

Is there any doc I can refer to understand the use case of this ?

@fin09pcap
Copy link
Member Author

fin09pcap commented May 26, 2022

Honestly I dont even know when and how we use that. Also as @franekrichardson said dont we need to append the p0 at the end or smth ? Anyway will defer this to someone else who knows what is all about.

This adjusts the Validator to determine if the provided region name is in the authorized list of region(s) per provider.
This change will allow for either additional characters in the prefix or the suffix as long as the region is defined for the appropriate cloud provider. i.e. ibm-syd-p1012 with the pod identifier is an allow value when defining the region in both the platform and infra KV path structure.

@fin09pcap fin09pcap merged commit 6724c2f into elastic:main Jun 10, 2022
@fin09pcap fin09pcap deleted the validator/ibm_region_name_updates branch June 10, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgolja dgolja dgolja approved these changes

@franekrichardson franekrichardson Awaiting requested review from franekrichardson

@nsilve nsilve Awaiting requested review from nsilve

Assignees

@fin09pcap fin09pcap

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fin09pcap @dgolja