Preserve empty untyped arrays when reifying#189
Merged
kvch merged 6 commits intoelastic:masterfrom Nov 10, 2021
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
|
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com>
Contributor
kvch
approved these changes
Nov 5, 2021
Contributor
|
@ruflin We should probably create a new release and adopt it in Beats soon. |
Contributor
|
@kvch SGTM, will you take care of it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #188
This adds a special case for empty arrays when reifying configuration objects during Unpack. This is a breaking change compared to existing behaviour as visible in the test cases I adjusted. The original issue #160 that introduced said tests is however still addressed.