[Flyout System] Improve validation and error logging#9091
Merged
tsullivan merged 1 commit intoelastic:feat/flyout-systemfrom Oct 10, 2025
Merged
Conversation
Collaborator
💚 Build Succeeded |
tkajtoch
reviewed
Oct 10, 2025
| error: FlyoutValidationError | ||
| ): string { | ||
| const prefix = `EuiFlyout validation error: `; | ||
| console.error(error); |
Member
There was a problem hiding this comment.
FYI We throw on console.error in test environment. We might need to adjust things if this affects other tests
Member
Author
There was a problem hiding this comment.
The test that consumes this file mocks console.error to avoid tests failing, but if other tests consume validation.ts and are hitting validation errors, they would be affected. Let me know if you think this would be an issue.
Collaborator
💚 Build Succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why are we making this change?
This allows developers using the Flyout System to better understand why validation errors occur, and to be able to correlate the message to their code.
Screenshots #
Impact to users
No impact to end users. Use cases that would throw validation errors should be fixed before the code is released.
QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles