[Flyout System] Remove isOpen prop#9083
Merged
tkajtoch merged 3 commits intoelastic:feat/flyout-systemfrom Oct 12, 2025
Merged
Conversation
e7124df to
a9cbb70
Compare
Collaborator
💚 Build SucceededHistory
cc @tkajtoch |
Collaborator
💚 Build Succeeded
History
cc @tkajtoch |
tsullivan
approved these changes
Oct 10, 2025
Member
tsullivan
left a comment
There was a problem hiding this comment.
LGTM! I love how this simplifies the implementation, results in better performance, and will keep animations consistent for all flyouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #9065
This PR removes the recently added
isOpenprop due to incompatibility with some of the flyout system features. The complexity of fixing the incompatibility ended up being more involving than just removing the supplementary prop I had previously decided would be worth having. We can still add theisOpenprop in the future if we decide it's worth it, but it's not related to the Flyout System project and can be safely omitted at this time.Why are we making this change?
This work is part of the Flyout System project.
Impact to users
isOpenprop removal has no impact on users since it existed only temporarily in a feature branch.QA
Regular flyouts
Toggle flyoutbutton toggles the visibility of the flyoutNote: Due to the removal of the
isOpenprop, there's no closing animation. That's expectedManaged flyouts - playground
Managed flyouts - Multi-session example
Session A - MainandSession A - Childflyouts disappear andSession B - Mainshows upSession A - MainandSession A - Childflyouts being visibleGeneral checklist