Skip to content

[Flyout System] Add the flyout overlay mask back#9077

Merged
tsullivan merged 8 commits intoelastic:feat/flyout-systemfrom
tkajtoch:feat/flyout-system-overlay
Oct 15, 2025
Merged

[Flyout System] Add the flyout overlay mask back#9077
tsullivan merged 8 commits intoelastic:feat/flyout-systemfrom
tkajtoch:feat/flyout-system-overlay

Conversation

@tkajtoch
Copy link
Copy Markdown
Member

@tkajtoch tkajtoch commented Oct 6, 2025

Summary

Resolves #8989

This PR reintroduces the previously removed overlay mask to the flyout component. The EuiOverlayMask was temporarily removed to simplify the development of other features and to be able to fix its buggy behavior separately.

The flyout elements are now rendered outside the overlay mask, which allows managed flyouts to render without unexpected flashes when updating the ownFocus prop or rerendering for other business logic reasons.

Note that this PR is marked as draft as the change to z-index values needs to be tested against Kibana. Other than a slight change to that value this PR should not change much. I tested the changes against Kibana and didn't find any broken flyouts due to the z-index change.

Why are we making this change?

It's part of the Flyout System M1 work. See the issue this resolves and the epic for more details.

Screenshots #

Impact to users

The change may affect z-index positioning of custom consumer-created elements if using values that aren't in line with what EUI expects.

The old logic included a behavior I was unaware of that used z-index: 6000 for flyouts when they were rendered with the overlay mask. The usual z-index value for flyouts is 1000. We're testing if changing the flyout z-index/level would have any negative impact on Kibana as this value would make way more sense semantically.

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA

@tkajtoch tkajtoch self-assigned this Oct 6, 2025
@tkajtoch tkajtoch marked this pull request as ready for review October 7, 2025 12:54
@tkajtoch tkajtoch requested a review from a team as a code owner October 7, 2025 12:54
Copy link
Copy Markdown
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reviewed the code and tested the overlay mask in the Storybook.

Great improvement to the DOM structure!

tsullivan and others added 2 commits October 15, 2025 11:17
@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

History

cc @tkajtoch

@elasticmachine
Copy link
Copy Markdown
Collaborator

💔 Build Failed

Failed CI Steps

History

cc @tkajtoch

@tsullivan tsullivan merged commit 801ecc6 into elastic:feat/flyout-system Oct 15, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants