[Flyout System] Add the flyout overlay mask back#9077
Merged
tsullivan merged 8 commits intoelastic:feat/flyout-systemfrom Oct 15, 2025
Merged
[Flyout System] Add the flyout overlay mask back#9077tsullivan merged 8 commits intoelastic:feat/flyout-systemfrom
tsullivan merged 8 commits intoelastic:feat/flyout-systemfrom
Conversation
# Conflicts: # packages/eui/src/components/flyout/manager/flyout_sessions.stories.tsx
…y removed wrapping `div` element
…act `style` prop validation error
af8ed2c to
35de275
Compare
tsullivan
approved these changes
Oct 15, 2025
Member
tsullivan
left a comment
There was a problem hiding this comment.
LGTM. Reviewed the code and tested the overlay mask in the Storybook.
Great improvement to the DOM structure!
# Conflicts: # packages/eui/src/components/flyout/manager/flyout_sessions.stories.tsx
Collaborator
💚 Build SucceededHistory
cc @tkajtoch |
Collaborator
💔 Build Failed
Failed CI StepsHistory
cc @tkajtoch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #8989
This PR reintroduces the previously removed overlay mask to the flyout component. The
EuiOverlayMaskwas temporarily removed to simplify the development of other features and to be able to fix its buggy behavior separately.The flyout elements are now rendered outside the overlay mask, which allows managed flyouts to render without unexpected flashes when updating the
ownFocusprop or rerendering for other business logic reasons.Note that this PR is marked as draft as the change toI tested the changes against Kibana and didn't find any broken flyouts due to thez-indexvalues needs to be tested against Kibana. Other than a slight change to that value this PR should not change much.z-indexchange.Why are we making this change?
It's part of the Flyout System M1 work. See the issue this resolves and the epic for more details.
Screenshots #
Impact to users
The change may affect
z-indexpositioning of custom consumer-created elements if using values that aren't in line with what EUI expects.The old logic included a behavior I was unaware of that used
z-index: 6000for flyouts when they were rendered with the overlay mask. The usualz-indexvalue for flyouts is1000. We're testing if changing theflyoutz-index/level would have any negative impact on Kibana as this value would make way more sense semantically.QA
Remove or strikethrough items that do not apply to your PR.
General checklist