[Flyout System] Allow flyout size to be undefined, default to ‘m’#9072
Merged
tsullivan merged 3 commits intoelastic:feat/flyout-systemfrom Oct 6, 2025
Conversation
5f84776 to
c8c15fb
Compare
c8c15fb to
d1aa960
Compare
tkajtoch
reviewed
Oct 3, 2025
Collaborator
💚 Build SucceededHistory
|
Collaborator
💚 Build Succeeded
History
|
tkajtoch
approved these changes
Oct 6, 2025
Member
tkajtoch
left a comment
There was a problem hiding this comment.
Thank you for addressing my comment above! LGTM 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, when EuiFlyout used the
session=truesetting, it required asizeprop to be passed. This PR makes thesizeprop optional, and defaults tomwhen it is not passed.Why are we making this change?
This change will ease the migration of "plain" flyouts in Kibana to use the
session=truesetting.Impact to users
Developers consuming EuiFlyout won't be forced to add a
sizeprop to migrate existing "plain" flyouts to use thesession=truesetting.QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles