Skip to content

[Flyout System] Allow flyout size to be undefined, default to ‘m’#9072

Merged
tsullivan merged 3 commits intoelastic:feat/flyout-systemfrom
tsullivan:flyout-system/migration-improvements-default-size
Oct 6, 2025
Merged

[Flyout System] Allow flyout size to be undefined, default to ‘m’#9072
tsullivan merged 3 commits intoelastic:feat/flyout-systemfrom
tsullivan:flyout-system/migration-improvements-default-size

Conversation

@tsullivan
Copy link
Copy Markdown
Member

@tsullivan tsullivan commented Oct 1, 2025

Summary

Previously, when EuiFlyout used the session=true setting, it required a size prop to be passed. This PR makes the size prop optional, and defaults to m when it is not passed.

Why are we making this change?

This change will ease the migration of "plain" flyouts in Kibana to use the session=true setting.

Impact to users

Developers consuming EuiFlyout won't be forced to add a size prop to migrate existing "plain" flyouts to use the session=true setting.

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@tsullivan tsullivan force-pushed the flyout-system/migration-improvements-default-size branch from 5f84776 to c8c15fb Compare October 1, 2025 21:57
@tsullivan tsullivan force-pushed the flyout-system/migration-improvements-default-size branch from c8c15fb to d1aa960 Compare October 1, 2025 22:22
@tsullivan tsullivan added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Oct 1, 2025
@tsullivan tsullivan marked this pull request as ready for review October 1, 2025 22:49
@tsullivan tsullivan requested a review from a team as a code owner October 1, 2025 22:49
@tkajtoch tkajtoch requested a review from a team October 3, 2025 12:52
@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

History

@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

History

@tsullivan tsullivan requested a review from tkajtoch October 6, 2025 14:39
Copy link
Copy Markdown
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my comment above! LGTM 🎉

@tsullivan tsullivan merged commit e252ac2 into elastic:feat/flyout-system Oct 6, 2025
4 checks passed
@tsullivan tsullivan deleted the flyout-system/migration-improvements-default-size branch October 6, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants