Skip to content

[Flyout System] Clean up storybooks#9070

Merged
tsullivan merged 1 commit intoelastic:feat/flyout-systemfrom
tsullivan:flyout-system/cleanup-storybooks
Oct 3, 2025
Merged

[Flyout System] Clean up storybooks#9070
tsullivan merged 1 commit intoelastic:feat/flyout-systemfrom
tsullivan:flyout-system/cleanup-storybooks

Conversation

@tsullivan
Copy link
Copy Markdown
Member

Summary

Core to declutter the list of storybooks for the Flyout System

Storybook name Filename Status
Basic Example (Shopping Cart) flyout_child.stories.tsx Removed: no longer suitable. The current API architecture considers a session to be a single main flyout with an optional child flyout, and the capability is to navigate from one session to another. This storybook was originally suitable because the previous architecture had the capability of holding multiple flyout pairs within a session that could be navigated among each other.
Fill-mode flyout_fill_mode.stories.tsx Removed: is redundant with the Playground story
Playground flyout_manager.stories.tsx Modified: includes fill-mode capabilities
Multi-session example flyout_sessions.stories.tsx Left as-is

Why are we making this change?

Clean up

Screenshots #

Before:

image

After:

image

Impact to users

Developer consumers of EUI will have better clarity of example code.

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@tsullivan tsullivan marked this pull request as ready for review September 30, 2025 15:37
@tsullivan tsullivan requested a review from a team as a code owner September 30, 2025 15:37
* Side Public License, v 1.
*/

import { Meta, StoryObj } from '@storybook/react';
Copy link
Copy Markdown
Member Author

@tsullivan tsullivan Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the "Shopping Cart" example. The contents of this file have been replaced with code that was previously in flyout_child.stories.tsx (Playground)

@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

@tsullivan tsullivan added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Sep 30, 2025
@tkajtoch tkajtoch self-requested a review October 3, 2025 12:21
Copy link
Copy Markdown
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I tested the updated stories in the PR environment and can confirm the changes work as expected.

Thank you for cleaning this up!

@tsullivan tsullivan merged commit 4538a3b into elastic:feat/flyout-system Oct 3, 2025
6 checks passed
@tsullivan tsullivan deleted the flyout-system/cleanup-storybooks branch October 3, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants