feat(eui): remove EuiLoadingChart non-mono version#8441
Merged
weronikaolejniczak merged 5 commits intoelastic:mainfrom Mar 18, 2025
Merged
Conversation
b2fde67 to
13b3c53
Compare
mgadewoll
reviewed
Mar 17, 2025
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
|
This PR contains breaking changes. The opener of this pull request is asked to perform the following due diligence steps below, to assist EUI in our next Kibana upgrade:
|
mgadewoll
approved these changes
Mar 18, 2025
Contributor
mgadewoll
left a comment
There was a problem hiding this comment.
🚢 Thanks for picking this up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
EuiLoadingChartnon-mono version (which is the default). I decided to remove instead of deprecate it and consulted the decision with @ek-so. We only need to update the code on the next Kibana upgrade by removing all mentions ofmonoprop. See the details below.Closes #8275
Impact
Cloud UI
There are 3 usages, all use the non-mono version, they do not pass the
monoprop, they don't require an update:cloud-ui/apps/monolith/public/components/User/BillingUsage/components/CostsChart/index.tsxcloud-ui/apps/monolith/public/components/User/BillingUsage/components/CostsChartByInstance/index.tsxcloud-ui/apps/monolith/public/components/User/BillingUsage/components/ProductChart/index.tsxKibana
24 times mono or mono={true} (requires code update)
Use regexp:
<EuiLoadingChart[^>]*\smono\s*(=\s*(\{?)\s*true\s*(\}?)\s*)?[^>]*>src/platform/packages/private/kbn-panel-loader/index.tsxsrc/platform/plugins/private/vis_default_editor/public/default_editor_controller.tsxsrc/platform/plugins/shared/dashboard/public/dashboard_renderer/grid/dashboard_grid_item.tsxsrc/platform/plugins/shared/vis_types/timeseries/public/application/components/timeseries_loading.tsxsrc/platform/plugins/shared/vis_types/timeseries/public/application/components/timeseries_visualization.tsxsrc/platform/plugins/shared/visualizations/public/components/visualization_container.tsxsrc/platform/plugins/shared/visualizations/public/embeddable/visualize_embeddable.tsxsrc/platform/plugins/shared/visualizations/public/legacy/embeddable/visualize_embeddable.tsxx-pack/platform/plugins/shared/aiops/public/components/mini_histogram/mini_histogram.tsxx-pack/platform/plugins/shared/dataset_quality/public/components/common/spark_plot.tsxx-pack/platform/plugins/shared/dataset_quality/public/components/dataset_quality_details/overview/document_trends/trend_docs_chart.tsxx-pack/platform/plugins/shared/ml/public/application/components/loading_indicator/loading_indicator.tsxx-pack/platform/plugins/shared/ml/public/application/explorer/swimlane_container.tsxx-pack/platform/plugins/shared/ml/public/embeddables/anomaly_charts/anomaly_charts_react_container.tsxx-pack/solutions/observability/plugins/apm/public/components/shared/charts/spark_plot/index.tsxx-pack/solutions/observability/plugins/infra/public/components/lens/chart_placeholder.tsxx-pack/solutions/observability/plugins/slo/public/components/alert_details/components/error_rate/error_rate_panel.tsxx-pack/solutions/observability/plugins/slo/public/pages/slo_details/components/wide_chart.tsxx-pack/solutions/observability/plugins/slo/public/pages/slo_details/components/events_chart_panel/events_chart_panel.tsxx-pack/solutions/observability/plugins/slo/public/pages/slo_edit/components/common/data_preview_chart.tsxx-pack/solutions/observability/plugins/slo/public/pages/slos/components/slo_sparkline.tsxx-pack/solutions/observability/plugins/synthetics/public/apps/synthetics/components/monitor_details/monitor_pending_wrapper.tsxx-pack/solutions/observability/plugins/ux/public/components/app/rum_dashboard/visitor_breakdown/index.tsxx-pack/solutions/security/plugins/security_solution/public/management/components/console/components/command_execution_output.tsx1 wrapper component (requires code update)
Name:
AsyncComponentSource:
x-pack/solutions/observability/plugins/profiling/public/components/async_component.tsxIt uses mono version once:
x-pack/solutions/observability/plugins/profiling/public/components/stack_traces/index.tsx: 1 mono, 1 non-monoand non-mono version 7 times:
x-pack/solutions/observability/plugins/profiling/public/components/stack_traces/index.tsxx-pack/solutions/observability/plugins/profiling/public/views/flamegraphs/differential_flamegraphs/index.tsxx-pack/solutions/observability/plugins/profiling/public/views/flamegraphs/flamegraph/index.tsxx-pack/solutions/observability/plugins/profiling/public/views/functions/differential_topn/index.tsxx-pack/solutions/observability/plugins/profiling/public/views/functions/topn/index.tsxx-pack/solutions/observability/plugins/profiling/public/views/storage_explorer/data_breakdown/index.tsxx-pack/solutions/observability/plugins/profiling/public/views/storage_explorer/host_breakdown/index.tsx37 times no mono prop
Use regexp:
<EuiLoadingChart(?![^>]*\smono\s*(=\s*(\{?)\s*true\s*(\}?)\s*)?)[^>]*>src/platform/packages/shared/kbn-alerts-ui-shared/src/alert_filter_controls/loading.tsxx-pack/platform/plugins/private/canvas/public/components/canvas_loading/canvas_loading.component.tsxx-pack/platform/plugins/private/data_usage/public/app/components/charts_loading.tsxx-pack/platform/plugins/private/watcher/public/application/sections/watch_edit_page/components/threshold_watch_edit/watch_visualization.tsxx-pack/platform/plugins/shared/logs_shared/public/components/loading/index.tsxx-pack/platform/plugins/shared/ml/public/application/jobs/jobs_list/components/datafeed_chart_flyout/datafeed_chart_flyout.tsxx-pack/platform/plugins/shared/stack_alerts/public/rule_types/threshold/visualization.tsxx-pack/platform/plugins/shared/streams_app/public/components/data_management/stream_detail_lifecycle/ingestion_rate.tsxx-pack/platform/plugins/shared/triggers_actions_ui/public/application/sections/alert_summary_widget/components/alert_summary_widget_loader.tsxx-pack/platform/plugins/shared/triggers_actions_ui/public/application/sections/common/components/execution_duration_chart.tsxx-pack/solutions/observability/plugins/apm/public/components/alerting/ui_components/chart_preview/chart_preview_helper.tsxx-pack/solutions/observability/plugins/apm/public/components/app/service_map/popover/stats_list.tsxx-pack/solutions/observability/plugins/apm/public/components/shared/charts/chart_container.tsxx-pack/solutions/observability/plugins/infra/public/alerting/common/criterion_preview_chart/criterion_preview_chart.tsxx-pack/solutions/observability/plugins/infra/public/components/asset_details/tabs/processes/process_row_charts.tsxx-pack/solutions/observability/plugins/infra/public/components/loading/index.tsxx-pack/solutions/observability/plugins/infra/public/pages/metrics/inventory_view/components/timeline/timeline.tsxx-pack/solutions/observability/plugins/observability/public/components/custom_threshold/components/criterion_preview_chart/criterion_preview_chart.tsxx-pack/solutions/observability/plugins/observability/public/pages/overview/components/chart_container/chart_container.tsxx-pack/solutions/observability/plugins/observability/public/pages/overview/components/sections/metrics/metrics_section.tsxx-pack/solutions/observability/plugins/profiling/public/embeddables/async_embeddable_component.tsxx-pack/solutions/observability/plugins/slo/public/components/slo/simple_burn_rate/burn_rate.tsxx-pack/solutions/observability/plugins/slo/public/embeddable/slo/burn_rate/burn_rate.tsxx-pack/solutions/observability/plugins/slo/public/embeddable/slo/error_budget/error_budget_burn_down.tsxx-pack/solutions/observability/plugins/slo/public/embeddable/slo/overview/slo_overview.tsxx-pack/solutions/observability/plugins/uptime/public/legacy_uptime/components/common/charts/chart_wrapper/chart_wrapper.tsxx-pack/solutions/observability/plugins/uptime/public/legacy_uptime/components/monitor/synthetics/step_detail/waterfall/waterfall_chart_container.tsxx-pack/solutions/observability/plugins/ux/public/components/app/rum_dashboard/chart_wrapper/index.tsxx-pack/solutions/search/plugins/enterprise_search/public/applications/analytics/components/analytics_collection_view/analytics_collection_overview/analytics_collection_chart.tsxx-pack/solutions/search/plugins/enterprise_search/public/applications/analytics/components/analytics_overview/analytics_collection_card/analytics_collection_card.test.tsxx-pack/solutions/search/plugins/enterprise_search/public/applications/analytics/components/analytics_overview/analytics_collection_card/analytics_collection_card.tsxx-pack/solutions/security/plugins/cloud_security_posture/public/components/chart_panel.tsxx-pack/solutions/security/plugins/security_solution/public/asset_inventory/components/top_assets_bar_chart.tsxx-pack/solutions/security/plugins/security_solution/public/asset_inventory/components/filters/filters_loading.tsxOut of regexp:
x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_creation_ui/components/rule_preview/loading_histogram.tsx(styled-component override)x-pack/solutions/observability/plugins/synthetics/public/apps/synthetics/components/step_details_page/step_waterfall_chart/waterfall/waterfall_chart_container.tsx(multiline)QA
EuiLoadingChartpass