Adds isDisabled prop to EuiComboBox#829
Merged
snide merged 5 commits intoelastic:masterfrom May 15, 2018
Merged
Conversation
legrego
approved these changes
May 15, 2018
Member
legrego
left a comment
There was a problem hiding this comment.
LGTM
This looks great, thanks for the quick turnaround! I left a small comment; feel free to address or ignore it.
| inputRef={this.searchInputRef} | ||
| updatePosition={this.updateListPosition} | ||
| onClear={isClearable && this.clearSelectedOptions ? this.clearSelectedOptions : undefined} | ||
| onClear={(isClearable && this.clearSelectedOptions && !isDisabled) ? this.clearSelectedOptions : undefined} |
Member
There was a problem hiding this comment.
What are your thoughts on pulling this out into a function? I feel like it might improve the readability now that there are three conditions being checked here.
Contributor
Author
|
jenkins test this |
This was referenced May 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #822
Adds
isDisabledprop toEuiComboBox. Will properly disable the input and remove button actions on the pills, clears and dropdown arrows.This does remove the item from screen readers since it isn't focusable. I tried a couple options but this is something sort of built into HTML and acts similar to our other inputs. I'm going to make an issue to try and think up something clever to fix this across our forms in general.