Skip to content

High contrast mode support#8232

Closed
cee-chen wants to merge 18 commits intomainfrom
high-contrast-mode
Closed

High contrast mode support#8232
cee-chen wants to merge 18 commits intomainfrom
high-contrast-mode

Conversation

@cee-chen
Copy link
Copy Markdown
Contributor

@cee-chen cee-chen commented Dec 12, 2024 •
edited
Loading

Summary

closes #8133. See also #7509 (comment)

Note

This is a feature branch. This means that it contains a massive changeset that has been reviewed in atomic chunks. Please see the below individual PRs for discussions, changes, and reviews:

QA

  • Generally smoke test the docs on both Mac and Windows high contrast modes to check for any visual issues

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
      - [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist - N/A - no designs for high contrast mode (currently)

cee-chen and others added 14 commits December 12, 2024 09:24
@cee-chen
[EuiProvider][EuiThemeProvider] highContrastMode set up and documen…
5fe668e 
…tation (#8142)
@cee-chen
Remove no-extra-semicolons stylelint rule
a55ed3d 
- at this point it's creating more false positives with nested template literals than it is being helpful
@cee-chen
[High Contrast Mode] Panels, modals, flyouts, toasts, popovers, and t…
8339bf7 
…ooltips (#8174)
@cee-chen
[High Contrast Mode] Form controls (#8193)
112f1e5
@cee-chen
[High Contrast Mode] Ranges, color pickers, and date pickers (#8199)
478ea3f
@cee-chen
[High Contrast Mode] Allow forced high contrast themes to also force …
7edd66c 
…color mode (#8200)
@cee-chen
[High contrast mode] DRY utilities (#8205)
7ca2a69
@cee-chen
[High Contrast Mode] Buttons, datepicker redux, code blocks, and avat…
569f13d 
…ars (#8210)
@cee-chen
[High Contrast Mode] Horizontal rules, side navs, tabs, and breadcrum…
5d0084b 
…bs (#8218)
@cee-chen
[High Contrast Mode] Loading components and beacons (#8215)
6c415ca
@cee-chen
[High Contrast Mode] Markdown, highlighting, misc text fixes (#8219)
841ef86
@cee-chen
[High Contrast Mode] EuiKeyPadMenu, EuiImage, EuiOverlayMask, EuiBott…
8e6f8c1 
…omBar, EuiToken (#8225)
@cee-chen
[High Contrast Mode] Steps, timelines, and comment lists (#8223)
82c62d4
@cee-chen
[High Contrast Mode] Tables and data grid (#8226)
bdbbdf6
@cee-chen cee-chen mentioned this pull request Dec 12, 2024
Closed
9 tasks
@cee-chen cee-chen marked this pull request as ready for review December 12, 2024 18:15
@cee-chen cee-chen requested a review from a team as a code owner December 12, 2024 18:15
@cee-chen
Copy link
Copy Markdown
Contributor Author

cee-chen commented Dec 12, 2024

I'll push up any minor visual tweaks/bugfixes directly to this PR. Already noticing one or two in the final smoke test 😅

mgadewoll
mgadewoll reviewed Dec 12, 2024
View reviewed changes
@mgadewoll
Copy link
Copy Markdown
Contributor

mgadewoll commented Dec 12, 2024

ℹ️ We won't merge this PR just yet as we first need to rebase and update Borealis with these changes. Otherwise the Borealis feature branch would be blocked from releases.

cee-chen and others added 3 commits December 12, 2024 21:18
@cee-chen
Update changelog file
0997448
@cee-chen
[PR feedback] Changelog typo
03229db
@mgadewoll @cee-chen
docs: ensure high contrast mode works in EUI+
578de0b 
- enables workspace EUI version for docusaurus-theme

- fixes theme vs colorMode setting on EuiProvider in EUI+
@cee-chen
Copy link
Copy Markdown
Contributor Author

cee-chen commented Dec 13, 2024 •
edited
Loading

I forced pushed to remove some of the component fixes I pre-emptively pushed up. I'm just going to open a new (last 💀) PR with various fixes and updates I found in my final review pass: #8234

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Dec 13, 2024

Preview staging links for this PR:

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Dec 13, 2024 •
edited
Loading

💚 Build Succeeded

History

@JasonStoltz JasonStoltz mentioned this pull request Jan 8, 2025
Closed
@mgadewoll mgadewoll mentioned this pull request Mar 14, 2025
Merged
12 tasks
@mgadewoll
Copy link
Copy Markdown
Contributor

mgadewoll commented Mar 14, 2025 •
edited
Loading

ℹ️ @cee-chen We finally are getting back to this! ⏲️ The changes done in your PR have been moved to this new PR to align them with the latest state of main and required updates for the new theme. I'm closing this PR in favor of the new one.

@mgadewoll mgadewoll closed this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgadewoll mgadewoll mgadewoll left review comments

Assignees

@mgadewoll mgadewoll

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Epic] Add High contrast mode

4 participants

@cee-chen @mgadewoll @kibanamachine @elasticmachine