[EuiModal] Adjust position of close button, end#8230
Closed
acstll wants to merge 3 commits intoelastic:mainfrom
Closed
[EuiModal] Adjust position of close button, end#8230acstll wants to merge 3 commits intoelastic:mainfrom
acstll wants to merge 3 commits intoelastic:mainfrom
Conversation
12 tasks
|
Preview staging links for this PR:
|
Collaborator
💔 Build Failed
Failed CI Steps |
|
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A possible fix for #7222 — a much simpler approach that simply places the close button last in the DOM (after first attempt on #8202).
Please read the comments there if you haven't: #8202 (review)
If this gets approved by accessibility specialists @alexwizp and @L1nBra, we can apply the same logic for #7223
I (still) need to figure out how to properly test the screen reader part.
QA
General checklist
Checked in mobileChecked in Chrome, Safari, Edge, and FirefoxAdded documentationProps have proper autodocs (using@defaultif default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesUpdated visual regression testsIf applicable, added the breaking change issue label (and filled out the breaking change checklist)If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)