[Docs] Update references to Sass/Emotion migration#8029
Merged
cee-chen merged 9 commits intoelastic:mainfrom Sep 20, 2024
Merged
[Docs] Update references to Sass/Emotion migration#8029cee-chen merged 9 commits intoelastic:mainfrom
cee-chen merged 9 commits intoelastic:mainfrom
Conversation
…migration + remove `colorMode` docs in anticipation of automatic system color mode logic, and link to EuiProvider props instead
+ move bottom bullet point to a location where it'll actually be read, and wrap it in a warning callout
- should be under styling section, where it's actually useful - add link to cache config, since that affects CSS specificity - modify example to be usable in codesandbox
+ refactor usage elsewhere
9de7e7d to
50bed56
Compare
- no need to import `.css` files any longer - remove context, use `useEuiTheme()` instead
+ remove duplicated README in `packges/eui` - half the links don't work anyway
50bed56 to
6bbfad7
Compare
JasonStoltz
approved these changes
Sep 20, 2024
Member
JasonStoltz
left a comment
There was a problem hiding this comment.
Hey Cee. These updates look comprehensive and I think we covered all of our bases here. Thanks for handling this!
b82d871 to
21c7470
Compare
Collaborator
💚 Build Succeeded
History
|
This was referenced Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code diffs can be a little hard to follow so I recommend following the QA steps below instead. I'm particularly looking for feedback on the developer experience and whether the copy/instructions would make sense to you as someone new to EUI (but not necessarily new to frontend dev).
QA
Setting up your applicationsection no longer has any imported.cssfilesStyling your applicationsection and confirm that it makes sense with your understanding of EUI's usage and does not reference Sass.website/EUI+ docs and confirm that the Getting Started page there matchessrc-doc'sGeneral checklist
N/A, docs only