[Storybook] Add stories for more components (form components) - Part 3#7790
Merged
mgadewoll merged 25 commits intoelastic:mainfrom Jun 6, 2024
Merged
Conversation
cee-chen
reviewed
Jun 3, 2024
cee-chen
reviewed
Jun 5, 2024
cee-chen
reviewed
Jun 5, 2024
cee-chen
reviewed
Jun 5, 2024
packages/eui/src/components/form/described_form_group/described_form_group.stories.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Jun 5, 2024
packages/eui/src/components/form/form_control_layout/form_control_layout.stories.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Jun 5, 2024
packages/eui/src/components/form/form_control_layout/form_control_layout.stories.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Jun 5, 2024
packages/eui/src/components/form/form_control_layout/form_control_layout.stories.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Jun 5, 2024
packages/eui/src/components/form/form_control_layout/form_control_layout.stories.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Jun 5, 2024
cee-chen
reviewed
Jun 5, 2024
packages/eui/src/components/form/form_control_layout/form_control_layout_delimited.stories.tsx
Show resolved
Hide resolved
cee-chen
reviewed
Jun 5, 2024
packages/eui/src/components/form/form_control_layout/form_control_layout.stories.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Jun 5, 2024
packages/eui/src/components/form/form_control_layout/form_control_layout_delimited.stories.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Jun 5, 2024
packages/eui/src/components/form/form_control_layout/form_control_layout_delimited.stories.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Jun 5, 2024
packages/eui/src/components/form/form_control_layout/form_control_layout_delimited.stories.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Jun 5, 2024
packages/eui/src/components/form/form_control_layout/form_control_layout_delimited.stories.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Jun 6, 2024
packages/eui/src/components/form/described_form_group/described_form_group.stories.tsx
Outdated
Show resolved
Hide resolved
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #7614
This PR adds more stories for form components:
Additionally this PR adds base VRT reference images based on the added stories.
QA
Confirm that the prop controls for all the below stories provide relevant controls and that those controls work as expected:
https://eui.elastic.co/pr_7790/storybook/index.html?path=/story/forms-euiform--playground
https://eui.elastic.co/pr_7790/storybook/index.html?path=/story/forms-euiform--error
https://eui.elastic.co/pr_7790/storybook/index.html?path=/story/forms-euiform-subcomponents-euiformrow--playground
https://eui.elastic.co/pr_7790/storybook/index.html?path=/story/forms-euiform-euiformfieldset--playground
https://eui.elastic.co/pr_7790/storybook/index.html?path=/story/forms-euiform-euiformfieldset-subcomponents-euiformlegend--playground
https://eui.elastic.co/pr_7790/storybook/index.html?path=/story/forms-euiform-euiformlabel--playground
https://eui.elastic.co/pr_7790/storybook/index.html?path=/story/forms-euiform-euiformerrortext--playground
https://eui.elastic.co/pr_7790/storybook/index.html?path=/story/forms-euiform-euiformhelptext--playground
https://eui.elastic.co/pr_7790/storybook/index.html?path=/story/forms-euiform-euiformcontrollayout--playground
https://eui.elastic.co/pr_7790/storybook/index.html?path=/story/forms-euiform-euiformcontrollayout--icon-shape
https://eui.elastic.co/pr_7790/storybook/index.html?path=/story/forms-euiform-euiformcontrollayoutdelimited--playground
https://eui.elastic.co/pr_7790/storybook/index.html?path=/story/forms-euiform-euidescribedformgroup--playground