[Emotion][perf] Memoize simpler medium-impact components#7638
Merged
cee-chen merged 7 commits intoelastic:mainfrom Apr 4, 2024
Merged
[Emotion][perf] Memoize simpler medium-impact components#7638cee-chen merged 7 commits intoelastic:mainfrom
cee-chen merged 7 commits intoelastic:mainfrom
Conversation
22 tasks
- note: conditional JSX not touched here because 'link or button' logic will be a separate future refactor
4260a51 to
5fb7f47
Compare
- note: conditional JSX not touched here because 'link or button' logic will be a separate future refactor
5fb7f47 to
e9e1dca
Compare
- not going to try anything fancy here, class components are a headache
+ array `.map()`
- a neat example of DRYing out existing perf attempts!
- no usages in Kibana
- `optionalChildren` isn't worth memoizing because children rerenders too often + move `.euiCallOut__icon` to header styles since it's only used in that DOM
e9e1dca to
8a4c58f
Compare
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
mgadewoll
approved these changes
Apr 4, 2024
Contributor
mgadewoll
left a comment
There was a problem hiding this comment.
🚢 🐈⬛ Everything looks great and looks/works as before 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #7561 efforts
These were fairly straightforward memoizations of the following components and their subcomponents:
useMemoand inline JSX here)QA
General checklist
- [ ] Checked in mobile- [ ] Checked for accessibility including keyboard-only and screenreader modes