[Emotion][perf] Remaining unmemoized button styles #7634
Merged
cee-chen merged 2 commits intoelastic:mainfrom Apr 1, 2024
Merged
[Emotion][perf] Remaining unmemoized button styles #7634cee-chen merged 2 commits intoelastic:mainfrom
cee-chen merged 2 commits intoelastic:mainfrom
Conversation
- requires creating a new map for compressed focus colors - move uncompressed focus color to base styles, makes more sense there anyway
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
|
22 tasks
JasonStoltz
approved these changes
Apr 1, 2024
Member
JasonStoltz
left a comment
There was a problem hiding this comment.
These changes look good to me. I think the refactor for uncompressed button styles makes sense, and all of the tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I missed these in #7541!
QA
General checklist
- [ ] Checked in mobile- [ ] Checked for accessibility including keyboard-only and screenreader modes