Skip to content

[Storybook] add stories for more components (letters I - L)#7589

Merged
mgadewoll merged 10 commits intoelastic:mainfrom
mgadewoll:storybook/7479-stories-i-l
Mar 21, 2024
Merged

[Storybook] add stories for more components (letters I - L)#7589
mgadewoll merged 10 commits intoelastic:mainfrom
mgadewoll:storybook/7479-stories-i-l

Conversation

@mgadewoll
Copy link
Copy Markdown
Contributor

@mgadewoll mgadewoll commented Mar 18, 2024 •
edited by tkajtoch
Loading

Summary

closes #7479

This PR adds stories for the following components:

  • EuiI18n (specific stories instead of playground as the variants are exclusive)
  • EuiI18nNumber (specific stories instead of playground as the variants are exclusive)
  • EuiIcon
  • EuiImage
  • EuiInlineEditText
  • EuiInlineEditTitle
  • EuiInnerText
  • EuiKeyPadMenu
  • EuiLink
  • EuiListGroup
  • EuiListGroupItem
  • EuiPinnableListGroup
  • EuiLoadingElastic
  • EuiLoadingChart
  • EuiLoadingSpinner
  • EuiLoadingLogo

And it updates the existing story for the following component:

  • EuiKeyPadMenuItem

QA

  • Confirm that the prop controls for all the below stories provide relevant controls and that those controls work as expected:

@mgadewoll mgadewoll added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) labels Mar 18, 2024
@mgadewoll mgadewoll marked this pull request as ready for review March 18, 2024 12:19
@mgadewoll mgadewoll requested a review from a team as a code owner March 18, 2024 12:19
@mgadewoll mgadewoll changed the title [Storybook] [Storybook] add stories for more components (letters I - L) Mar 18, 2024
tkajtoch
tkajtoch reviewed Mar 19, 2024
View reviewed changes
tkajtoch
tkajtoch reviewed Mar 19, 2024
View reviewed changes
tkajtoch
tkajtoch reviewed Mar 19, 2024
View reviewed changes
tkajtoch
tkajtoch reviewed Mar 19, 2024
View reviewed changes
@tkajtoch
Copy link
Copy Markdown
Member

tkajtoch commented Mar 19, 2024

I noticed a few very minor things, but other than that, the PR looks excellent, and all controls work as expected!

tkajtoch
tkajtoch approved these changes Mar 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 21, 2024

Preview staging links for this PR:

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Mar 21, 2024

💚 Build Succeeded

History

@mgadewoll mgadewoll merged commit 14a1759 into elastic:main Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tkajtoch tkajtoch tkajtoch approved these changes

Assignees

No one assigned

Labels

documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[New docs] Create stories for components starting with the letters I-L

4 participants

@mgadewoll @tkajtoch @kibanamachine @elasticmachine