[Emotion] Memoize EuiPanel + color/padding hook utilities + EuiResizableContainer/Panel#7584
Merged
cee-chen merged 12 commits intoelastic:mainfrom Mar 21, 2024
Merged
Conversation
- in anticipation of upcoming memoization
+ remove unnecessary fn from static styles
…orCSS` - Skipping `useEuiBackgroundColor` the extra `method` throws a wrench into things and it's not actually used by any components
- because this style has a 3rd level of nesting and our typing only goes down to 2, I've opted to just get rid of the strict typing completely. The return type correctly interprets the output in any case - this also lets us get rid of a `<any>` usage
- valid for Emotion - also, not sure how this hasn't come up before??
22 tasks
cee-chen
commented
Mar 15, 2024
cee-chen
commented
Mar 15, 2024
cee-chen
commented
Mar 15, 2024
mgadewoll
reviewed
Mar 18, 2024
- used by Kibana after all, and color computations are expensive, so we should memoize it
- at some minor/potential cost to performance
a301ab9 to
4fba5e7
Compare
Collaborator
💚 Build Succeeded
History
|
|
Preview staging links for this PR:
|
mgadewoll
approved these changes
Mar 21, 2024
Contributor
mgadewoll
left a comment
There was a problem hiding this comment.
🚢 🐈⬛ LGTM!
Thanks for the additional updates for improved readability. 🙏
Contributor
Author
|
Thanks so much for the fantastic PR feedback Lene!! You made this code so much more readable! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is an Emotion performance pass of the following components/utilities:
EuiPanelEuiResizablePanel(+ all otherEuiResizableContainercomponents while here)useEuiPaddingCSS)useEuiBackgroundColorCSS&useEuiBorderColorCSS)As always, I recommend following along by commit.
QA
General checklist
- [ ] Checked in mobile- [ ] Checked for accessibility including keyboard-only and screenreader modesand cypress tests