[Storybook] Add Playground stories for components with letter H#7553
Merged
mgadewoll merged 12 commits intoelastic:mainfrom Mar 7, 2024
Merged
[Storybook] Add Playground stories for components with letter H#7553mgadewoll merged 12 commits intoelastic:mainfrom
mgadewoll merged 12 commits intoelastic:mainfrom
Conversation
cee-chen
reviewed
Mar 6, 2024
cee-chen
reviewed
Mar 6, 2024
cee-chen
reviewed
Mar 6, 2024
cee-chen
reviewed
Mar 6, 2024
cee-chen
reviewed
Mar 6, 2024
cee-chen
reviewed
Mar 6, 2024
cee-chen
reviewed
Mar 6, 2024
cee-chen
reviewed
Mar 6, 2024
Contributor
|
Amazing first PR Lene!! 🎉 My comments are mostly minor - hopefully they make sense, but feel free to let me know if not! |
-ensure capitilization mismatch is covered -add separate story for multiple search strings
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
Contributor
|
Changes look great Lene! I'd love to see the controls categories for EDIT: Per above discussion, we'll handle that and prop categories in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #7478
This PR adds "Playground" stories for the following components:
QA
Confirm that the prop controls for all the below storybooks work as expected:
https://eui.elastic.co/pr_7553/storybook/index.html?path=/story/euiheaderbreadcrumbs--playground
https://eui.elastic.co/pr_7553/storybook/index.html?path=/story/euiheaderlink--playground
https://eui.elastic.co/pr_7553/storybook/index.html?path=/story/euihealth--playground
https://eui.elastic.co/pr_7553/storybook/index.html?path=/story/euihighlight--playground
https://eui.elastic.co/pr_7553/storybook/index.html?path=/story/euihorizontalrule--playground
https://eui.elastic.co/pr_7553/storybook/index.html?path=/story/euihidefor--playground