Skip to content

[Storybook] Add playground stories for components beginning with the letter A#7457

Merged
cee-chen merged 5 commits intoelastic:mainfrom
cee-chen:storybook/a
Jan 11, 2024
Merged

[Storybook] Add playground stories for components beginning with the letter A#7457
cee-chen merged 5 commits intoelastic:mainfrom
cee-chen:storybook/a

Conversation

@cee-chen
Copy link
Copy Markdown
Contributor

@cee-chen cee-chen commented Jan 10, 2024 •
edited
Loading

Summary

Adds playground storybooks for all EUI components beginning with the letter A (+ accessibility components). Only 25 more letters to go!

QA

General checklist

N/A, docs only

@cee-chen cee-chen added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) labels Jan 10, 2024
@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Jan 10, 2024

Preview staging links for this PR:

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Jan 10, 2024

💚 Build Succeeded

@cee-chen cee-chen marked this pull request as ready for review January 10, 2024 23:48
@cee-chen cee-chen requested a review from a team as a code owner January 10, 2024 23:48
@JasonStoltz
Copy link
Copy Markdown
Member

JasonStoltz commented Jan 11, 2024

Haha, the alphabet approach. ❤️ it.

@JasonStoltz
Copy link
Copy Markdown
Member

JasonStoltz commented Jan 11, 2024

Screenshot 2024-01-11 at 2 53 07 PM

Is there an approach in our toolkit for dealing with props like isLoadingMessage that require a ReactNode?

@cee-chen
Copy link
Copy Markdown
Contributor Author

cee-chen commented Jan 11, 2024

Is there an approach in our toolkit for dealing with props like isLoadingMessage that require a ReactNode?

Not for Storybook (there's nothing that allows raw JSX), but for simpler stuff I've been changing the control type to a string so that devs/users can at least type something in there and have it show up. I thought I did that for isLoadingMessage, let me double check

@cee-chen
Copy link
Copy Markdown
Contributor Author

cee-chen commented Jan 11, 2024

@JasonStoltz this is what I'm seeing on staging - not totally sure how you get to the object button!

@cee-chen cee-chen merged commit d7e0bdc into elastic:main Jan 11, 2024
@cee-chen cee-chen deleted the storybook/a branch January 11, 2024 22:12
@tkajtoch tkajtoch mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JasonStoltz JasonStoltz JasonStoltz approved these changes

Assignees

No one assigned

Labels

documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cee-chen @kibanamachine @elasticmachine @JasonStoltz