[EuiCollapsibleNavBeta] Fix accordion open animation bug#7317
Merged
cee-chen merged 2 commits intoelastic:mainfrom Oct 27, 2023
Merged
[EuiCollapsibleNavBeta] Fix accordion open animation bug#7317cee-chen merged 2 commits intoelastic:mainfrom
cee-chen merged 2 commits intoelastic:mainfrom
Conversation
- this bug only seems to happen when EuiAccordion is the last item the group
- the issue is that the `margin` isn't being accounted for when calculating the height, which is throwing off the open logic
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
|
JasonStoltz
approved these changes
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QA
Observabilityaccordion arrowAIOpsand click that accordion arrowGeneral checklist
- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] Checked in both light and dark modes