Skip to content

[EuiHeader] Scrapped spike - complex map logic for fixed headers#7152

Closed
cee-chen wants to merge 1 commit intoelastic:theme-css-variablesfrom
cee-chen:header-css-var-map
Closed

[EuiHeader] Scrapped spike - complex map logic for fixed headers#7152
cee-chen wants to merge 1 commit intoelastic:theme-css-variablesfrom
cee-chen:header-css-var-map

Conversation

@cee-chen
Copy link
Copy Markdown
Contributor

@cee-chen cee-chen commented Sep 1, 2023

This PR was only opened for code archival purposes and potential future reference. See #7144 (review) for more context.

I did spike out an approach for this that uses a Map to store individual header heights, but honestly, at the end of it all when I stood there looking at the final code, I couldn't justify adding the extra complexity for something that I can almost guarantee no consumer is going to use. I'd rather wait to get an actual feature request for it first.

I'll probably still open a draft PR with the working spike and then close it to preserve the code in case some absolute madman out there does want it in the future, but I don't intend on initially shipping with support for it.

@cee-chen cee-chen changed the title Scrapped spike - complex map logic [EuiHeader] Scrapped spike - complex map logic for fixed headers Sep 1, 2023
@cee-chen cee-chen closed this Sep 1, 2023
@cee-chen cee-chen deleted the header-css-var-map branch September 1, 2023 17:17
@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_7152/

@elasticmachine
Copy link
Copy Markdown
Collaborator

💔 Build Failed

Failed CI Steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants