[wiki] Add CSS variables docs to our Emotion wiki#7145
Merged
cee-chen merged 2 commits intoelastic:theme-css-variablesfrom Sep 1, 2023
Merged
[wiki] Add CSS variables docs to our Emotion wiki#7145cee-chen merged 2 commits intoelastic:theme-css-variablesfrom
cee-chen merged 2 commits intoelastic:theme-css-variablesfrom
Conversation
- ideally should also clearly explain when to use CSS variables, but I'm not sure this is totally clear
1Copenut
reviewed
Aug 31, 2023
wiki/contributing-to-eui/developing/writing-styles-with-emotion.md
Outdated
Show resolved
Hide resolved
wiki/contributing-to-eui/developing/writing-styles-with-emotion.md
Outdated
Show resolved
Hide resolved
wiki/contributing-to-eui/developing/writing-styles-with-emotion.md
Outdated
Show resolved
Hide resolved
wiki/contributing-to-eui/developing/writing-styles-with-emotion.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Trevor Pierce <1Copenut@users.noreply.github.com>
Contributor
Author
|
Fantastic suggestions, thank you Trevor! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an example of how components can set CSS variables. Ideally should also clearly explain when to use CSS variables, but I'm not sure this is totally clear and my brain is a little fried right now, so would appreciate feedback.
BTW, I definitely anticipate us tweaking these docs more as we move on to converting form components to and actually have to set up CSS variables for them.
QA
General checklist
N/A, wiki/docs only