[Docs] Remove isNew flag from EuiSkeleton components#7050
Merged
cee-chen merged 1 commit intoelastic:mainfrom Aug 7, 2023
Merged
[Docs] Remove isNew flag from EuiSkeleton components#7050cee-chen merged 1 commit intoelastic:mainfrom
isNew flag from EuiSkeleton components#7050cee-chen merged 1 commit intoelastic:mainfrom
Conversation
- Have been public for 6 months now, so no longer "new"
isNew flag from EuiSkeleton componentsisNew flag from EuiSkeleton components
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_7050/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_7050_buildkite/ |
breehall
approved these changes
Aug 7, 2023
Contributor
breehall
left a comment
There was a problem hiding this comment.
Both of the "new" flags no longer appear! This is good to go 🚀
Collaborator
💚 Build Succeeded
|
Contributor
Author
|
Thanks Bree! FYI: Something funky is going on with Jenkins; going to ignore the pending status on that and admin merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #7021
Our
EuiSkeletoncomponents have been publicly available for ~6 months now, and should no longer be considered "new".QA
Skeletoncomponent in the side nav does not have a "NEW" badgeGeneral checklist
N/A, docs only