[babel] Upgrade babel-loader, babel-template, and misc babel plugins to latest#6812
Merged
cee-chen merged 3 commits intoelastic:mainfrom May 26, 2023
Merged
[babel] Upgrade babel-loader, babel-template, and misc babel plugins to latest#6812cee-chen merged 3 commits intoelastic:mainfrom
babel-loader, babel-template, and misc babel plugins to latest#6812cee-chen merged 3 commits intoelastic:mainfrom
Conversation
- and grab other babel minors/latest patches while we're here + run prettier on file calling old `babel-template` and remove unused eslint disables
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6812/ |
1Copenut
approved these changes
May 26, 2023
Contributor
1Copenut
left a comment
There was a problem hiding this comment.
👍 LGTM! I ran through your QA steps one by one. Each passed with no issues.
I started the server locally using yarn start and tested a number of components' props and playgrounds. Did the same with different, random components on the preview URL.
Contributor
Author
|
Fantastic!! Thank you so much for the thorough QA Trevor! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Meta issue: closes #6652
babel-loaderto latest (note: our various webpack deps could probably stand to be upgraded as well at another point in time)babel-templateto@babel/template, and fixes its import/usagebabel-plugins to latest if available@babel/dependencies to latest that have been released since this meta issue started 🥲QA
yarn startyarn build-pack(checkout all changed files after)yarn build-docs(checkout all changed files after)yarn test-cypress-devyarn combine-test-coverage